-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yaml for WS2022 nodes #1189
Add yaml for WS2022 nodes #1189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this. The 2022 manifest appears to be identical to the existing manifest, except for the image tag.
I don't think the level of duplication here is ideal, but the complexity of the manifests isn't enough to warrant a helm chart (not that I could support one anyway).
Do you think it would be worth updating the tag in the existing manifest?
That would be a solution for WS2022 nodes - hopefully that's what people are using these days, but then it becomes a problem for people running WS2019, hence my proposal for a separate file. |
Just so I understand correctly, for windows containers the image and node must match? I.E. a Windows 2019 node cannot run 2022 container images? |
That is correct. And the images are version specific. |
That is correct. And the images are version specific. More info here: https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility?tabs=windows-server-2022%2Cwindows-11 |
Thanks for enlightening me on this, I wasn't aware of the Windows container/host restrictions. If you sign the commit (to pass the DCO check) I'll get this merged. |
#signed-off-by: Vinicius Apolinario viniap@microsoft.com |
@vrapolinario you'll need to sign the commit with |
Signed-off-by: vrapolinario <viniap@microsoft.com>
3fffb0e
to
0db5504
Compare
Sorry for the delay - KubeCon and all. I have just signed the commit following the instructions. Apologies as my Git abilities are very limited. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a problem, thanks for updating it.
…-msft-ws2022 Add yaml for WS2022 nodes
Adding a yaml spec with an image supported on Windows Server 2022 nodes.