Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the fluent-style usage of kingpin by an dedicated instance of kingpin. This allow programs to embed windows_exporter and pass a customized kingpin instance to all collectors.
At the moment, its hard to embedded windows_exporter in an other application. While its possible to feed the
kingpin.CommandLine
instance outside from windows_exporter, there are conflicts with other exporters do the same.PR tested in a Windows 10 client machine.
Example Code for injected collector configuration into the embedded windows_exporter instance: