Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Deprecate whitelist/blacklist flags #1170

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

breed808
Copy link
Contributor

@breed808 breed808 commented Apr 1, 2023

Flags have been deprecated in favour of include/exclude terminology.

This addresses #679. Resolution of the issue will occur when the flags are removed.

@breed808 breed808 requested a review from a team as a code owner April 1, 2023 07:53
@breed808 breed808 added this to the v0.23.0 milestone Apr 1, 2023
@breed808 breed808 force-pushed the include_exclude branch 2 times, most recently from c0f2de6 to c883505 Compare April 18, 2023 20:04
@breed808 breed808 changed the title feat: Deprecate whitelist/blacklist flags feat!: Deprecate whitelist/blacklist flags Apr 18, 2023
Flags have been deprecated in favour of include/exclude terminology.

Signed-off-by: Ben Reedy <breed808@breed808.com>
@breed808
Copy link
Contributor Author

@jkroepke note that I've changed the flag constant names in this PR, they'll need to be updated for any embedded windows_exporter instances.
This should be the only time I break things by changing the flag names.

@jkroepke
Copy link
Member

jkroepke commented Apr 18, 2023

@breed808 I was ware of this PR.

Do it. Do it now, before next release 👍

It should break nothing at least on my site, because there is not release which includes the current yet. I consider anything as unstable until tis released.


Aside from my mind I really appreciate your mention here!

@breed808 breed808 merged commit 76c435d into prometheus-community:master Apr 18, 2023
@JDA88
Copy link
Contributor

JDA88 commented Jul 21, 2023

How long do you plan to keep the olds flags working in // of the new ones?

@breed808
Copy link
Contributor Author

@JDA88 I like to leave the old flags for at least another two releases (I.E. removing the old flags in v0.26.0), but this will depend on the future release cadence.

If there's enough work on the exporter to warrant another two releases in a short period of time, I'd expect the old flags to remain for more than two releases

@breed808 breed808 deleted the include_exclude branch July 23, 2023 22:01
@JDA88
Copy link
Contributor

JDA88 commented Jul 24, 2023

If there's enough work on the exporter to warrant another two releases in a short period of time, I'd expect the old flags to remain for more than two releases

Thanks for the info, this one will require a little refactoring on our side

anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
…clude

feat!: Deprecate whitelist/blacklist flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants