-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Deprecate whitelist/blacklist flags #1170
feat!: Deprecate whitelist/blacklist flags #1170
Conversation
6efebd5
to
de711d8
Compare
c0f2de6
to
c883505
Compare
Flags have been deprecated in favour of include/exclude terminology. Signed-off-by: Ben Reedy <breed808@breed808.com>
c883505
to
fab77d9
Compare
@jkroepke note that I've changed the flag constant names in this PR, they'll need to be updated for any embedded windows_exporter instances. |
@breed808 I was ware of this PR. Do it. Do it now, before next release 👍 It should break nothing at least on my site, because there is not release which includes the current yet. I consider anything as unstable until tis released. Aside from my mind I really appreciate your mention here! |
How long do you plan to keep the olds flags working in // of the new ones? |
@JDA88 I like to leave the old flags for at least another two releases (I.E. removing the old flags in If there's enough work on the exporter to warrant another two releases in a short period of time, I'd expect the old flags to remain for more than two releases |
Thanks for the info, this one will require a little refactoring on our side |
…clude feat!: Deprecate whitelist/blacklist flags
Flags have been deprecated in favour of include/exclude terminology.
This addresses #679. Resolution of the issue will occur when the flags are removed.