Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix documentation error #1144

Merged
merged 1 commit into from
Mar 18, 2023
Merged

docs: fix documentation error #1144

merged 1 commit into from
Mar 18, 2023

Conversation

fuxingZhang
Copy link
Contributor

Fix the documentation and code inconsistencies caused by the following commit.

e9c5944

@fuxingZhang fuxingZhang requested a review from a team as a code owner March 2, 2023 03:14
@fuxingZhang fuxingZhang changed the title docs: fix documentation errors docs: fix documentation error Mar 2, 2023
breed808
breed808 requested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, I missed it in the initial implementation.

--web.config.file should instead be --web.listen-address, as that's the replacement flag. --web.config.file is documented further down in this list.

@fuxingZhang
Copy link
Contributor Author

fuxingZhang commented Mar 3, 2023 •
edited
Loading

The commit modifies the listening address, not the configuration file.

image

image

@breed808
Copy link
Contributor

That's correct, but your change introduces a second --web.config.file entry in the README:
Screenshot_20230312_092815

@fuxingZhang
Copy link
Contributor Author

Sorry for my carelessness

@fuxingZhang
docs: fix documentation errors
931c3f7 
Fix the documentation and code inconsistencies caused by the following commit
> e9c5944

Signed-off-by: zfx <fuxing.zhang@qq.com>
@fuxingZhang
Copy link
Contributor Author

@breed808 I've modified the commit.

breed808
breed808 approved these changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating it 👍

@breed808 breed808 merged commit 0dc4aca into prometheus-community:master Mar 18, 2023
@fuxingZhang fuxingZhang deleted the patch-1 branch March 20, 2023 02:28
anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
@breed808
Merge pull request prometheus-community#1144 from fuxingZhang/patch-1
68a10c0 
docs: fix documentation error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breed808 breed808 breed808 approved these changes

Assignees
No one assigned
Labels
📖 docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuxingZhang @breed808