-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibily with new flag web.listen-address #1096
Conversation
Signed-off-by: Brandon Kauffman <bck01215@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this, I must have missed it in e9c5944
I agree this change is necessary but as it’s a breaking change, can we have both parameter working at least until the |
There's no easy way to have both options working correctly, as the exporter toolkit we rely on requires the new flag. The There is the option of continuing to run v0.20.0 until you are ready for v0.21.0 or v0.22.0. |
Ok, I understand. |
Technically both flags could be included, but from memory the only the new flag would be properly used by the exporter, due to the change in behavior for the exporter toolkit. |
I'll try to test this. It should ease our migration path. |
OK after some test you can't use both flag at the same time, you get the error message: We will adjust our deployement script to check for the version of the binary and change the command line in consequence |
Compatibily with new flag web.listen-address
Signed-off-by: Brandon Kauffman bck01215@gmail.com