fix: Remove memory leaks in scheduled_task #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breed808
force-pushed
the
scheduled_task_memory
branch
from
3af1317
to
d936d2d
Compare
OLE objects must be manually cleared or released to prevent leaks. Note that these objects do not appear in the heap, so the pprof heap profiles aren't helpful in identifying OLE leaks. Resident memory continues to increase if objects are not properly cleared. Signed-off-by: Ben Reedy <breed808@breed808.com>
breed808
force-pushed
the
scheduled_task_memory
branch
from
d936d2d
to
25d2385
Compare
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…task_memory fix: Remove memory leaks in scheduled_task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OLE objects must be manually cleared or released to prevent leaks. Note that these objects do not appear in the heap, so the pprof heap profiles aren't helpful in identifying OLE leaks.
Graph below shows exporter running with the
scheduled_taskcollector enabled, withcurlquerying the metrics endpoint continuously. First part of graph is the exporter built frommaster, second part is the exporter built from this feature branch.Resolves #1063