Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated deps to newest version and allow both react 16 and 17 as a peer #860 #861

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Updated deps to newest version and allow both react 16 and 17 as a peer #860 #861

merged 3 commits into from
Jul 23, 2021

Conversation

rkesters
Copy link
Contributor

@rkesters rkesters commented Jul 11, 2021 •
edited
Loading

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer/coffee because you are awesome

What?

Update deps to support react 16 and react 17. Ensured the devDeps used compatible versions.

Why?

  • The package does not use anything that is specific to React 17, hence it compatiable with both React 16 and 17.
  • Out of the box the stroybook package would not run, this had to do we mismatched versions
  • Use opportunity to update all deps to latest, no breaking changes

How?

  • made changes to package.json files
  • updated 1 test file to support jest 27

@rkesters rkesters marked this pull request as ready for review July 11, 2021 02:05
@rkesters
Copy link
Contributor Author

@dylanvorster please review.

dylanvorster
dylanvorster reviewed Jul 11, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@rkesters
Copy link
Contributor Author

@dylanvorster please review.

@dylanvorster dylanvorster merged commit 77e1abb into projectstorm:master Jul 23, 2021
@dylanvorster
Copy link
Member

I am going to rebump all packages though, I think peer deps can include 16, but dev version should be 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanvorster dylanvorster dylanvorster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkesters @dylanvorster