Update DiagramWidget.tsx #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the proposed fix for the issue that I just logged: projectstorm#258
|
Thanks for this pull request, it solves an issue I'm having. Will a new version including this be released to NPM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed fix for the issue that I just logged: #258
Checklist
yarn run prettyWhat?
Fixes issue where closing context menu caused a state where it was stuck in MoveCanvasAction with no mouse button pressed.
Why?
So that the issue doesn't happen.
How?
One line change. Don't run any of the mousedown logic if you right click.
Feel-Good "programming lol" image:
(Add your own one below :])