Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stringsutil.ContainsAll func #446

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

dogancanbakir
Copy link
Member

Closes #445

@dogancanbakir dogancanbakir self-assigned this Jun 24, 2024
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I'm thinking if maybe we should make it case insensitive by default, or add another method like ContainsAllI(...) (maybe as a follow up). What do you think?

@dogancanbakir dogancanbakir merged commit 08a61a6 into main Jun 25, 2024
7 checks passed
@dogancanbakir dogancanbakir deleted the add_containsall_func branch June 25, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement stringsutil.ContainsAll
2 participants