Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mapsutil #13

Closed
7 tasks done
edoardottt opened this issue Nov 6, 2022 · 0 comments · Fixed by #14
Closed
7 tasks done

Update mapsutil #13

edoardottt opened this issue Nov 6, 2022 · 0 comments · Fixed by #14
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.

Comments

@edoardottt
Copy link
Contributor

  • Merge instead of MergeMaps (mapsutil.Merge)
  • HTTPRequestToMap test
  • HTTPResponseToMap test
  • Add Clear function
  • Add SliceToMap function & test
  • Fix test using ElementsMatch (Tests should ignore map iteration order #12)
  • Add IsEmpty function
This was referenced Nov 6, 2022
Merged
Closed
ehsandeep pushed a commit that referenced this issue Nov 6, 2022
@edoardottt @Mzack9999
Update mapsutil #13 (#14)
c62b9b7 
* Update mapsutil #13

* refactoring clear func

* adding clear's tests

* fixing execs on windows

* run sh only on unix system

Co-authored-by: Mzack9999 <mzack9999@protonmail.com>
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update mapsutil #13
2 participants
@ehsandeep @edoardottt