SQL schema migration fixes and testing #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There does not appear to be an alternative way to set individual config options, and this is already used by test/ejabberd_SUITE.erl
- check that server_host column does not already exist before addding it and making other changes to table (update_sql becomes idempotent, yay!) - check that indexes exist before dropping them (some are historical and are not created in more recent deployments), elminating spurious errors from logs - update new_sql_schema config after migration, to allow near zero-downtime migrations (and help with automated testing)
To test update_sql operation and functionality of resulting DB:
1. Load original schema to DB
2. Set {update_sql, true} in suite.erl
3. Run tests
... and make the test that uncovered it explicitly fail (there was already a TODO) instead of passing but with errors logged
nosnilmot
force-pushed
the
sql-update-tests
branch
from
6b23fb0
to
0c1cf43
Compare
|
To follow :) |
|
Took me some time to review it, but it all looks sensible. Let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be controversial, but it was necessary for the next item. Is there another way to change config settings at runtime?
And enable them in github actions - only run if changes are detected in schema or update_sql code (it would be good to also run this at least once pre-release, but it might be overkill to run for every change)
And enable them in github actions
Same bug as vcard_iq_set crashed when running mod_vcard:vcard_iq_set/1 #3695 which was fixed for new installations but not for upgrades. The fix for any existing impacted installations is the same:
finding that bug almost made all the effort to enable automated schema upgrade testing worthwhile