Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0163 - owner did not receive any PEP notifications after initial presence stanza #2112

Closed
Torxen opened this issue Nov 17, 2017 · 2 comments · Fixed by #2167
Closed

XEP-0163 - owner did not receive any PEP notifications after initial presence stanza #2112

Torxen opened this issue Nov 17, 2017 · 2 comments · Fixed by #2167
Assignees

Comments

@Torxen
Copy link

Torxen commented Nov 17, 2017

What version of ejabberd are you using?

17.09

What operating system (version) are you using?

CentOS Linux 7 (Core)

How did you install ejabberd (source, package, distribution)?

source

What did not work as expected? Are there error messages in the log? What
was the unexpected behavior? What was the expected result?

As described in XEP-0163: Personal Eventing Protocol after publishing an event the owner should receive his own notifications on every resource even if the resource was offline. After the fix from yesterday XEP-0163 - owner did not receive any PEP notifications (thanks for the quick turnaround) the owner only receives his notification if he is online. As described in in XEP-163 - Notify Last every new ressource of the owner should also get the notification, which is not working until now.

As mentioned, a PEP service MUST send the last published item to all new subscribers and to all newly-available resources for each subscriber, including the account owner itself.

Thanks

@cromain cromain self-assigned this Nov 20, 2017
@cromain cromain added this to the ejabberd 18.x milestone Nov 20, 2017
@cromain cromain modified the milestones: ejabberd 18.x, ejabberd 17.12 Dec 13, 2017
@cromain
Copy link
Contributor

cromain commented Dec 13, 2017

for PEP, we first need the client's CAPS. As we don't trigger pubsub last items on presence_probe, we may need an extra hook to be able to handle the PEP (with caps) case. Maybe caps_add hook will be needed to cover this case.

@lock
Copy link

lock bot commented Jun 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants