Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install notifications #307

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Install notifications #307

merged 4 commits into from
Sep 22, 2024

Conversation

CalebQ42
Copy link
Contributor

  • Added notifications when installing appimaged
    • Only shown when run without a terminal
    • Previously there was no feedback when appimaged was launched via GUI
    • Shows a fail or success message
  • Added app name to notifications
    • Gnome a major release or two started always showing app name in notifications, causing all appimaged notifications to say "unknown app"
  • Update deps and Go version

@github-actions GitHub Actions
Copy link

Build for testing:
artifacts
Use at your own risk.

@probonopd
Copy link
Owner

Thanks @CalebQ42. When appimaged is launched by systemd on each startup, there should not be a notification. Is this the case?

@CalebQ42
Copy link
Contributor Author

Nope, it only shows the notification if it creates the service file.

@probonopd probonopd merged commit 526ac12 into probonopd:master Sep 22, 2024
1 check passed
@probonopd
Copy link
Owner

Thanks @CalebQ42

This was referenced Sep 22, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalebQ42 @probonopd