Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Move content of tox.ini to pyproject.toml #693

Closed
wants to merge 3 commits into from
Closed

[Proposal] Move content of tox.ini to pyproject.toml #693

wants to merge 3 commits into from

Conversation

marvinpfoertner
Copy link
Collaborator

@marvinpfoertner marvinpfoertner commented Mar 29, 2022 •
edited
Loading

In a Nutshell

  • This PR removes the last tool configuration file (tox.ini) and moves the configuration into pyproject.toml.

Detailed Description

See above

Related Issues

#686

@marvinpfoertner marvinpfoertner added improvement Improvements of existing functionality testing and CI Unit tests, coverage and continuous integration labels Mar 29, 2022
@marvinpfoertner marvinpfoertner self-assigned this Mar 29, 2022
@marvinpfoertner marvinpfoertner requested a review from a team as a code owner March 29, 2022 11:37
@marvinpfoertner
Copy link
Collaborator Author

@JonathanWenger what are your thoughts about this?

@marvinpfoertner marvinpfoertner force-pushed the tox-ini-pyproject-toml branch 2 times, most recently from 5c8ac99 to 0c0f566 Compare March 29, 2022 14:01
@JonathanWenger
Copy link
Contributor

JonathanWenger commented Mar 29, 2022 •
edited
Loading

While pyproject.toml does not officially support tox configuration, I have a slight preference to keep a separate tox.ini configuration file. This seems very slightly more maintainable and maybe a little less susceptible to bugs. This is a very weakly held opinion however.

@marvinpfoertner
Copy link
Collaborator Author

While pyproject.toml does not officially support tox configuration, I have a slight preference to keep a separate tox.ini configuration file. This seems very slightly more maintainable and maybe a little less susceptible to bugs. This is a very weakly held opinion however.

Alright, then let's close this for now and wait until there is proper support for pyproject.toml configuration in tox :+1

@marvinpfoertner marvinpfoertner deleted the tox-ini-pyproject-toml branch February 6, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marvinpfoertner marvinpfoertner

Labels
improvement Improvements of existing functionality testing and CI Unit tests, coverage and continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinpfoertner @JonathanWenger