Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set vendored-openssl feature to fix issue with OpenSSL version mismatch between Node 18 and some systems #3724

Closed
wants to merge 1 commit into from

Conversation

Auspicus
Copy link

@Auspicus Auspicus commented Feb 18, 2023

This probably isn't the "best" way to fix the issue but I built the library with and without this and was able to confirm it fixes the issue. It will increase build size of the library (~20%) but it prevents the issue with system OpenSSL and Node OpenSSL using different versions. It implies that the libraries will need to be built for each version of OpenSSL used by Node, not the system.

eg:

  • libquery_engine-darwin-arm64-node18.dylib.node
  • libquery_engine-darwin-arm64-node16.dylib.node
  • ...

Fixes: prisma/prisma#10649

See also: https://github.com/prisma/prisma-engines/pull/3243/files which removed this but was never cut into a release.

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2023

CLA assistant check
All committers have signed the CLA.

@tomhoule
Copy link
Contributor

Hi @Auspicus , thanks for opening the discussion, but I think we want to investigate all other options to fix prisma/prisma#10649 before we make a drastic move like this. The number 1 reason why we don't want to statically link to a TLS implementation is security: keeping the system OpenSSL version up to date should be part of running any application, on the other hand asking people to upgrade their Prisma version, and rebuild their application to get a security patch is a much higher hurdle. And as you noted, binary size suffers as well. Let's continue the discussion in the issue. FWIW we are actively working on fixing this.

@tomhoule tomhoule closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault crash when using prisma client when using PostgreSQL
3 participants