-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #15779 - Closing nested dialog removes CSS class still needed f… #15845
Conversation
…or parent dialog
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes. |
@@ -266,6 +267,13 @@ export class DynamicDialogComponent implements AfterViewInit, OnDestroy { | |||
return this.config?.templates?.closeicon; | |||
} | |||
|
|||
get dynamicDialogCount() { | |||
let dynamicDialogs = this.document.querySelectorAll('p-dynamicdialog'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use const
instead of let
because the variables will not be reasigned
Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes. |
Fixes #15779