Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyFilter: No longer working on chips component #15531

Closed
ethanolree opened this issue May 10, 2024 · 0 comments · Fixed by #15967 · 4 remaining pull requests
Closed

KeyFilter: No longer working on chips component #15531

ethanolree opened this issue May 10, 2024 · 0 comments · Fixed by #15967 · 4 remaining pull requests
Assignees
@mehmetcetin01140
Labels
LTS-FIXED-15.4.23 LTS-FIXED-16.9.13 LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.4

Comments

@ethanolree
Copy link

Describe the bug

Previously, the keyFilter directive worked fine with the chips component, however, with a recent change, it no longer works correctly.

image
With this addition, the nativeElement.value is undefined so when an attempt to validate the input is made, it's validating on the string 'undefined' + cc

Environment

PrimeNG

Reproducer

No response

Angular version

17.13.1

PrimeNG version

17.15.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

I should be able to use the keyFilter on the chips input component
@ethanolree ethanolree added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 10, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jul 5, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 5, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.4 milestone Jul 5, 2024
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jul 5, 2024
Merged
cetincakiroglu added a commit that referenced this issue Jul 11, 2024
@cetincakiroglu
Merge pull request #15967 from primefaces/issue-15531
a88ce3d 
Fixed #15531 - KeyFilter | No longer working on chips component
@Rodolphe33 Rodolphe33 mentioned this issue Aug 2, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Aug 9, 2024
Open
@lakshamanr lakshamanr mentioned this issue Aug 9, 2024
Open
This was referenced Aug 16, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
LTS-FIXED-15.4.23 LTS-FIXED-16.9.13 LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.4
2 participants
@mehmetcetin01140 @ethanolree