Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action view renderer & JSON support #16

Merged
merged 11 commits into from
May 15, 2018
Merged

Action view renderer & JSON support #16

merged 11 commits into from
May 15, 2018

Conversation

michelson
Copy link
Contributor

This PR introduces a more Rails-ish way to render the views. using the ActionView renderer method from rails 5. Also this PR introduces the JSON support.

@coveralls
Copy link

coveralls commented May 14, 2018

Pull Request Test Coverage Report for Build 55

  • 78 of 91 (85.71%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.3%) to 91.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/policy_manager/exporter/view.rb 11 12 91.67%
lib/policy_manager/exporter/handler.rb 14 15 93.33%
lib/policy_manager/config.rb 0 2 0.0%
lib/policy_manager/exporter/json_view.rb 25 27 92.59%
app/helpers/policy_manager/exporter_helper.rb 14 17 82.35%
lib/policy_manager/exporter/json_link.rb 5 9 55.56%
Totals Coverage Status
Change from base Build 48: 10.3%
Covered Lines: 797
Relevant Lines: 874

💛 - Coveralls

@michelson michelson merged commit ee52ed6 into master May 15, 2018
@michelson michelson deleted the action-view-renderer branch May 15, 2018 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants