-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve doc print #1922
Improve doc print #1922
Conversation
Wow nice, I didn't know about |
It is probably time to upgrade to more modern prettier and drop support for older nodejs versions. I tried this somewhat recently, and there is a lot to fix, this is a great first step. |
@alexander-akait done 🎉 |
This looks great. |
It took us long enough to get this merged 🙈 thanks again @fisker! |
Released in |
I was going to help remove the deprecated
concat
command, but I found we are still running tests withprettier@2.1.2
, are we going to continue to support old version?Anyway,
eslint-plugin-prettier-doc
should be useful whenever you decide to removeconcat()
.Changes in this PR are problems caught by other rules in
eslint-plugin-prettier-doc
.