chore: update prettier to 2.1.2 #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
commented
Jun 26, 2021
| @@ -1102,7 +1102,7 @@ function printLines(path, options, print, childrenAttribute = "children") { | |||
| const beforeCloseTag = lastNode | |||
| ? concat([ | |||
| hasNewlineInRange( | |||
| options.originalText, | |||
| options.originalText.trimEnd(), | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
makes sense based on prettier changes
czosel
commented
Jun 26, 2021
| @@ -103,6 +103,7 @@ $foo = "bar"; | |||
| \`\`\` | |||
|
|
|||
| \`\`\`php | |||
|
|
|||
There was a problem hiding this comment.
Upstream prettier does this as well (see playground); the change was introduced here: prettier/prettier@97b899b#diff-0a8624d0b561d808de85774597ac5c1de4ac029c6f47e5f68a31ffb457db60eeR36
czosel
force-pushed
the
update-prettier-2-1-1
branch
from
41d06c9
to
9570d39
Compare
czosel
changed the title
cseufert
approved these changes
Jun 28, 2021
| @@ -1102,7 +1102,7 @@ function printLines(path, options, print, childrenAttribute = "children") { | |||
| const beforeCloseTag = lastNode | |||
| ? concat([ | |||
| hasNewlineInRange( | |||
| options.originalText, | |||
| options.originalText.trimEnd(), | |||
There was a problem hiding this comment.
makes sense based on prettier changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.