feat(php8 hanging comma) Add support for haning comma for functions, closures, arrow functions and methods

[cseufert]

This patch requires the PHP parser support for hanging commas glayzzle/php-parser#756

closes #1759

[alexander-akait]

Anyway good job!

[czosel]

Looks great otherwise 👍

[justim]

This change also adds a comma after "parameters" in a use block for a closure — which it should, but the resulting code can not be parsed again.

Input:

<?php

$test = function (SomeClass $one, SomeOtherClass $two, AndAnotherOne $three)
  use ($one, $two, $three, $four, $five, $six, $seven, $eight, $nine, $ten, $eleven)
{
}

Output:

<?php

$test = function (
    SomeClass $one,
    SomeOtherClass $two,
    AndAnotherOne $three,
) use (
    $one,
    $two,
    $three,
    $four,
    $five,
    $six,
    $seven,
    $eight,
    $nine,
    $ten,
    $eleven,
) {};

And using the output as input again give the following message:

Parse Error : syntax error, unexpected ')', expecting T_VARIABLE on line 19

  17 |     $ten,
  18 |     $eleven,
> 19 | ) {};
  20 |

See Prettier playgrounds: before and after.

Is this a quick fix? Or do you want me to look into it?

[alexander-akait]

@czosel here bug

[justim]

That's not the latest version you're looking at. It currently links to the right commit on master, and the latest version of this PR as well.

The parses doesn't understand the extra ,.

[alexander-akait]

@justim your code should work, can you open an new issue (before please test it on the latest version)