-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phpVersion option #1286
Add phpVersion option #1286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, to summarize this:
- We should consider making
trailingCommaPHP
a boolean. (Objections?) - We should test (and accordingly fix) flexible nowdoc blocks.
Everything else looks fine to me.
EDIT: P.S.:
This does not exactly belong here, but I haven't found a good place to drop this, so you'll get it here:
I have adjusted the playground the other day. For local development, you can now pick a standalone.js
file from your system that's then used by the playground. I wanted to have this for a while, mostly for easily accessing the AST (astexplorer.net obviously does not have our version of the parser), but you might find it useful as well. 🙂
Awesome! 💯 Looking forward to give this a try 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I think we're good to go.
phpVersion
trailingCommaPHP
phpX.X
optionsall
Probably it's best to review the commits separately 😉
Based on #1285