Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update parser and add arrow function support #1277

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented Jan 3, 2020

No description provided.

@czosel czosel force-pushed the arrow-functions branch 3 times, most recently from 5855cc5 to 6819874 Compare January 3, 2020 21:34
@czosel
Copy link
Collaborator Author

czosel commented Jan 3, 2020

@vjeux We recently switched to Github Actions, and still see AppVeyor builds in our PRs even though both the config file and the webhook were removed. Maybe it's triggered by a "organization webhook"? Would you have any way of shutting it down?

cc @lydell @evilebottnawi

@czosel
Copy link
Collaborator Author

czosel commented Jan 5, 2020

@loilo friendly ping 😉

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@czosel czosel merged commit 79578a9 into prettier:master Jan 6, 2020
@czosel czosel deleted the arrow-functions branch January 6, 2020 19:33
@vjeux
Copy link
Contributor

vjeux commented Jan 8, 2020

@czosel yup, there seems to be an organization webhook for appveyor. Do you know who set it up by any chance? I have no idea how it works and don't want to break it :x

@czosel
Copy link
Collaborator Author

czosel commented Jan 8, 2020

😅 : I suspect @ikatyang, see prettier/prettier#7223

@vjeux
Copy link
Contributor

vjeux commented Jan 8, 2020

@ikatyang can you delete the org wide appveyor setting since it seems to have been moved to actions?

@ikatyang
Copy link
Member

Sorry for the late response, I've uninstalled the AppVeyor GitHub App for this org.

@czosel
Copy link
Collaborator Author

czosel commented Jan 10, 2020

Thank you @ikatyang 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants