Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(retif): correct parentheses for bin in retif #1257

Merged
merged 1 commit into from
Dec 22, 2019
Merged

fix(retif): correct parentheses for bin in retif #1257

merged 1 commit into from
Dec 22, 2019

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented Dec 22, 2019

Fixes #1245

@czosel czosel requested a review from loilo December 22, 2019 18:19
loilo
loilo approved these changes Dec 22, 2019
View reviewed changes
Copy link
Collaborator

@loilo loilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@czosel czosel merged commit a863ce1 into master Dec 22, 2019
@czosel czosel deleted the fix-retif-parens branch December 22, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loilo loilo loilo approved these changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removes parentheses when "and" is combined with ternary expression
2 participants
@czosel @loilo