Rename trailingComma to trailingCommaPHP

[flexchar]

Rename trailingComma property to trailingCommaPHP in order to prevent collisions with other Prettier plugins/implementations.

As discussed in #964

[alexander-akait]

Let's support also options.trailingComma for all and none for better integration

[alexander-akait]

All good, one note

[flexchar]

Since 'none' is none despite option being present or not, I only add check for 'all'.

[alexander-akait]

/cc @czosel

[czosel]

👍

[alexander-akait]

@czosel can you do release? because we are below 1.0 we can release this as minor, don't forget add infromation about this to release page

[czosel]

@evilebottnawi done. Is the text sufficient? https://github.com/prettier/plugin-php/releases/tag/v0.11.0

[alexander-akait]

@czosel yes 👍

[loilo]

What about the CLI option? Current v0.11.0 still uses --trailing-comma instead of --trailing-comma-php.

[alexander-akait]

Need update too

[czosel]

Shall I try reverting the release or shall we publish a fix as 0.11.1?

[alexander-akait]

@czosel yes, looks we do broken release, we should merge this and do release

[czosel]

🤦‍♂️ I didn't realize that this wasn't merged yet.

[czosel]

I just unpublished 0.11.0 - the current master is good for release, right?

[alexander-akait]

Yes

[czosel]

Published as 0.11.1

[loilo]

Alright, playground has been updated. 👍

[flexchar]

@evilebottnawi thanks for getting this out!
Did I miss CLI option as mentioned by @loilo? I can't seem to find any code for it thou...

[alexander-akait]

/cc @loilo

[loilo]

I only tested with the 0.11.0 version @czosel published before merging the PR so I guess I actually tested 0.10.2 under the 0.11.0 label. 😁

Since there were no further commits for 0.11.1, I assume that your PR was completely fine @flexchar. ❤️
Sorry for the confusion.

[czosel]

I also apologize for the broken release - next time I won’t cut a release while sitting in a meeting 😅