Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client-tag selector rule in presto-router #23790

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saravanan19
Copy link

Description

When the client-tags matches the request, the selector should choose the target group. The bug in the code doesn't do that. In th current code, when all the client-tags match incoming request, the selector is not matched.

Motivation and Context

When the client-tags matches the request, the selector should choose the target group. The bug in the code doesn't do that. In th current code, when all the client-tags match incoming request, the selector is not matched.

Impact

None

Test Plan

Verified manually by passing client-tags in the request and tried to match the client-tags configured in the selector. After the fix, it matches and the right target group is used

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

@saravanan19 saravanan19 requested a review from a team as a code owner October 9, 2024 04:40
Copy link

CLA Not Signed

@saravanan19 saravanan19 changed the title Fix client-tag selector rule. Fix client-tag selector rule in presto-router Oct 9, 2024
@tdcmeehan tdcmeehan self-assigned this Oct 9, 2024
@tdcmeehan
Copy link
Contributor

Any way to add a unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants