Add build param to skip creating hardlinks #23782
Open
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
steveburnett
requested changes
Oct 8, 2024
singcha
force-pushed
the
make-hard-links-configurable
branch
from
8e6e5b5
to
5e110d9
Compare
tdcmeehan
reviewed
Oct 8, 2024
README.md
Outdated
Comment on lines
36
to
39
| Presto uses the [Provisio](https://github.com/jvanzyl/provisio) plugin for packaging using hard links. If your filesystem doesn't support hard links, you can bypass hard links using: | ||
|
|
||
| ./mvnw clean install -presto.hard-link-includes='' | ||
|
|
There was a problem hiding this comment.
My sense is that the vast majority of filesystems folks use do support hardlinks. If that's the case, this is a very prominent callout in the README for relatively esoteric information. I would remove it, and perhaps add a comment in the POM instead.
There was a problem hiding this comment.
IMO - Anyone setting up project & building it, is going to look in README file for build instructions. Please let me know if you still think we should remove it and I can update the PR
There was a problem hiding this comment.
Maybe let's create a section toward the bottom for common issues with the build. For now, we can just put this there, but add other stuff as needed (incorrect JDK, Maven timeouts, etc).
Presto build fails when a filesystem with no support for hardlinks is used. Add new param to specify hardlink include jars.
singcha
force-pushed
the
make-hard-links-configurable
branch
from
5e110d9
to
49ac257
Compare
tdcmeehan
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presto build fails when a filesystem with no support for hardlinks is used. Add new param to specify hardlink include jars.
Motivation and Context
Fixes build issue when underlying filesystem doesn't support hardlinks
Test Plan
Built on devserver
== NO RELEASE NOTE ==