-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated feature group-by-uses-equal #22888
Remove deprecated feature group-by-uses-equal #22888
Conversation
22e3fbf
to
a060870
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[INFO] There is 1 error reported by Checkstyle 8.16 with src/checkstyle/presto-checks.xml ruleset.
Error: src/test/java/com/facebook/presto/hive/TestHivePageSink.java:[36,8] (imports) UnusedImports: Unused import - com.facebook.presto.sql.analyzer.FeaturesConfig.
Remove deprecated legacy behavior for group by to use equal to rather than distinct. Remove the corresponding config `deprecated.group-by-uses-equal`
a060870
to
2e8f70d
Compare
Can you give a brief context on what this feature is and why we are removing it? |
The original implementation of group by in Presto was incorrectly using equal to rather than is distinct from. When that was fixed, this config was added to use the legacy behavior baad26e. It's been deprecated a long time, and I think we can safely remove it now. |
Description
Remove deprecated legacy behavior for group by to use equal to rather than distinct. Remove the corresponding config
deprecated.group-by-uses-equal
Motivation and Context
Clean up of deprecated/not maintained feature.
Impact
see above
Test Plan
CI
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.