Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Remove spill stats reporting from presto native #22751

Merged
merged 1 commit into from
May 15, 2024
Merged

[native] Remove spill stats reporting from presto native #22751

merged 1 commit into from
May 15, 2024

Conversation

tanjialiang
Copy link
Contributor

Removes spill related stats reporting from presto native. Migrated the reporting to velox's PeriodicStatsReporter.

== RELEASE NOTES ==
Since there are metrics removed from reporting, dashboards might be affected. Migrate the dashboard to point to the velox reported metrics instead.
The removed spill related metrics are going to be replaced by velox reported metrics in the following way:
original: presto_cpp.spill_metrics_name
new: velox.spill_metrics_name

@tanjialiang tanjialiang requested a review from a team as a code owner May 15, 2024 04:01
xiaoxmeng
xiaoxmeng approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjialiang thanks!

@tanjialiang tanjialiang merged commit 6c682f5 into prestodb:master May 15, 2024
59 checks passed
@wanglinsong wanglinsong mentioned this pull request Jun 25, 2024
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanjialiang @xiaoxmeng