array_join adds an extra delimeter if the last element is null #22652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
array_join adds an extra trailing delimeter to the result string if the last element in the array is null
Motivation and Context
this seems to be clearly incorrect, if the null replacement argument isn't set nulls are otherwise ignored by array_join
Impact
this will change the results of array_join for cases where the last element is null
Test Plan
added a testcase where the null replacement argument is not set and the last element is null, this was previously untested
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.