Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Preserve case for RowType's field name and JSON content when CAST"" #22618

Merged

Conversation

hantangwangd
Copy link
Member

This reverts commit 9c13a6a.

Description

This PR add back the changes in PR #21869 as discussed in #22604 (comment). And add a release note of fixing the incorrect behaviors with duplicate field names in RowType that maybe omitted in #21869.

Test Plan

Unit Tests

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==

General Changes
* Fix incorrect behaviors when defining duplicate field names in RowType and throw exception uniformly. 

Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff b4af7c4...9234f87.

Notify File(s)
@steveburnett presto-docs/src/main/sphinx/admin/properties.rst
presto-docs/src/main/sphinx/functions/json.rst

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local build of docs. Thanks!

@hantangwangd hantangwangd merged commit 9a20c79 into prestodb:master Apr 26, 2024
57 checks passed
@hantangwangd hantangwangd deleted the re_revert_preserve_case_when_cast branch April 26, 2024 18:24
@wanglinsong wanglinsong mentioned this pull request Jun 25, 2024
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants