Implement collection of min/max values in DynamicFilterSourceOperator #16314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kewang1024 you might be interested in this PR |
|
CC: @beinan |
beinan
reviewed
Jun 27, 2021
presto-main/src/test/java/com/facebook/presto/operator/TestDynamicFilterSourceOperator.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/DynamicFilterSourceOperator.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/DynamicFilterSourceOperator.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/DynamicFilterSourceOperator.java
Show resolved
Hide resolved
|
Ping :) |
beinan
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
looks good to me. @kewang1024 do you want to take a second look?
kewang1024
reviewed
Jul 6, 2021
presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/LocalExecutionPlanner.java
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/operator/TestDynamicFilterSourceOperator.java
Show resolved
Hide resolved
Cherry-picked from trinodb/trino#3871 as well as the relevant code from the following commits: - trinodb/trino@f401bfe - trinodb/trino@f7dd1de - trinodb/trino@c224b48 - trinodb/trino@e0d1846 - trinodb/trino@b87425e Co-authored-by: Raunaq Morarka <raunaqmorarka@gmail.com> Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com> Co-authored-by: Michael Chirico <michael.chirico@grabtaxi.com>
kewang1024
approved these changes
Jul 7, 2021
|
Many thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from trinodb/trino#3871
Co-authored-by: Raunaq Morarka raunaqmorarka@gmail.com