Use new Nan definition in math function test

prestodb · Apr 3, 2024 · f0a642f · f0a642f
1 parent 1a4f99b
commit f0a642f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/presto-main/src/test/java/com/facebook/presto/operator/scalar/AbstractTestFunctions.java b/presto-main/src/test/java/com/facebook/presto/operator/scalar/AbstractTestFunctions.java
@@ -76,7 +76,9 @@ protected AbstractTestFunctions(FeaturesConfig config)
     protected AbstractTestFunctions(Session session, FeaturesConfig config)
     {
         this.session = requireNonNull(session, "session is null");
-        this.config = requireNonNull(config, "config is null").setLegacyLogFunction(true);
+        this.config = requireNonNull(config, "config is null")
+                .setLegacyLogFunction(true)
+                .setUseNewNanDefinition(true);
     }
 
     @BeforeClass

diff --git a/presto-main/src/test/java/com/facebook/presto/operator/scalar/TestMathFunctions.java b/presto-main/src/test/java/com/facebook/presto/operator/scalar/TestMathFunctions.java
@@ -1127,9 +1127,6 @@ public void testGreatest()
         assertFunction("greatest(1.0, 2.0E0)", DOUBLE, 2.0);
         assertDecimalFunction("greatest(5, 4, 3.0, 2)", decimal("0000000005.0"));
 
-        // invalid
-        assertInvalidFunction("greatest(1.5E0, 0.0E0 / 0.0E0)", "Invalid argument to greatest(): NaN");
-
         // argument count limit
         tryEvaluateWithAll("greatest(" + Joiner.on(", ").join(nCopies(127, "rand()")) + ")", DOUBLE);
         assertNotSupported(
@@ -1204,6 +1201,7 @@ public void testLeast()
     @Test
     public void testGreatestWithNaN()
     {
+        // this test runs with useNewNanDefinition=false, as that is the default value
         assertFunction("greatest(1.5E0, 0.0E0 / 0.0E0)", DOUBLE, Double.NaN);
         assertFunction("greatest(REAL '1.5E0', REAL '0.0' / REAL '0.0')", REAL, Float.NaN);
     }