Skip to content

Commit

Permalink
[verifier] Filter out limit-without-order queries only when not skipp…
Browse files Browse the repository at this point in the history
…ing control & checksum
  • Loading branch information
mshang816 authored and aditi-pandit committed May 23, 2024
1 parent 968f9ad commit 584636f
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public class VerificationManager
private final int verificationResubmissionLimit;
private final boolean explain;
private final boolean skipControl;
private final boolean skipChecksum;
private final String runningMode;

private final ExecutorService executor;
Expand Down Expand Up @@ -151,6 +152,7 @@ public VerificationManager(
this.queryRepetitions = config.getQueryRepetitions();
this.verificationResubmissionLimit = config.getVerificationResubmissionLimit();
this.skipControl = config.isSkipControl();
this.skipChecksum = config.isSkipChecksum();
this.explain = config.isExplain();

this.executor = newFixedThreadPool(maxConcurrency);
Expand Down Expand Up @@ -267,7 +269,7 @@ private List<SourceQuery> filterQueryType(List<SourceQuery> sourceQueries)
else if (controlQueryType != testQueryType) {
postEvent(VerifierQueryEvent.skipped(sourceQuery.getSuite(), testId, sourceQuery, MISMATCHED_QUERY_TYPE, skipControl));
}
else if (isLimitWithoutOrderBy(controlStatement, sourceQuery.getName())) {
else if (!skipControl && !skipChecksum && isLimitWithoutOrderBy(controlStatement, sourceQuery.getName())) {
log.debug("LimitWithoutOrderByChecker Skipped %s", sourceQuery.getName());
postEvent(VerifierQueryEvent.skipped(sourceQuery.getSuite(), testId, sourceQuery, NON_DETERMINISTIC, skipControl));
}
Expand Down

0 comments on commit 584636f

Please sign in to comment.