Remove methods that override identical methods in the superclass

prestodb · Apr 18, 2024 · 219196b · 219196b
1 parent 7e03528
commit 219196b
Show file tree

Hide file tree

Showing 28 changed files with 2 additions and 356 deletions.
diff --git a/...src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcFilterToSqlTranslator.java b/...src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcFilterToSqlTranslator.java
@@ -38,7 +38,6 @@
 import com.facebook.presto.spi.function.FunctionMetadataManager;
 import com.facebook.presto.spi.relation.CallExpression;
 import com.facebook.presto.spi.relation.ConstantExpression;
-import com.facebook.presto.spi.relation.LambdaDefinitionExpression;
 import com.facebook.presto.spi.relation.SpecialFormExpression;
 import com.facebook.presto.spi.relation.VariableReferenceExpression;
 import com.google.common.base.Joiner;
@@ -90,12 +89,6 @@ public TranslatedExpression<JdbcExpression> translateVariable(VariableReferenceE
                 ImmutableList.of());
     }
 
-    @Override
-    public TranslatedExpression<JdbcExpression> translateLambda(LambdaDefinitionExpression lambda, Map<VariableReferenceExpression, ColumnHandle> context, RowExpressionTreeTranslator<JdbcExpression, Map<VariableReferenceExpression, ColumnHandle>> rowExpressionTreeTranslator)
-    {
-        return untranslated(lambda);
-    }
-
     @Override
     public TranslatedExpression<JdbcExpression> translateCall(CallExpression call, Map<VariableReferenceExpression, ColumnHandle> context, RowExpressionTreeTranslator<JdbcExpression, Map<VariableReferenceExpression, ColumnHandle>> rowExpressionTreeTranslator)
     {

diff --git a/...to-bytecode/src/main/java/com/facebook/presto/bytecode/instruction/InvokeInstruction.java b/...to-bytecode/src/main/java/com/facebook/presto/bytecode/instruction/InvokeInstruction.java
@@ -416,12 +416,6 @@ public List<Object> getBootstrapArguments()
             return bootstrapArguments;
         }
 
-        @Override
-        public List<BytecodeNode> getChildNodes()
-        {
-            return ImmutableList.of();
-        }
-
         @Override
         public <T> T accept(BytecodeNode parent, BytecodeVisitor<T> visitor)
         {

diff --git a/...a/com/facebook/presto/plugin/clickhouse/optimization/ClickHouseFilterToSqlTranslator.java b/...a/com/facebook/presto/plugin/clickhouse/optimization/ClickHouseFilterToSqlTranslator.java
@@ -38,7 +38,6 @@
 import com.facebook.presto.spi.function.FunctionMetadataManager;
 import com.facebook.presto.spi.relation.CallExpression;
 import com.facebook.presto.spi.relation.ConstantExpression;
-import com.facebook.presto.spi.relation.LambdaDefinitionExpression;
 import com.facebook.presto.spi.relation.SpecialFormExpression;
 import com.facebook.presto.spi.relation.VariableReferenceExpression;
 import com.google.common.base.Joiner;
@@ -90,12 +89,6 @@ public TranslatedExpression<ClickHouseExpression> translateVariable(VariableRefe
                 ImmutableList.of());
     }
 
-    @Override
-    public TranslatedExpression<ClickHouseExpression> translateLambda(LambdaDefinitionExpression lambda, Map<VariableReferenceExpression, ColumnHandle> context, RowExpressionTreeTranslator<ClickHouseExpression, Map<VariableReferenceExpression, ColumnHandle>> rowExpressionTreeTranslator)
-    {
-        return untranslated(lambda);
-    }
-
     @Override
     public TranslatedExpression<ClickHouseExpression> translateCall(CallExpression call, Map<VariableReferenceExpression, ColumnHandle> context, RowExpressionTreeTranslator<ClickHouseExpression, Map<VariableReferenceExpression, ColumnHandle>> rowExpressionTreeTranslator)
     {

diff --git a/...asticsearch/src/test/java/com/facebook/presto/elasticsearch/ElasticsearchQueryRunner.java b/...asticsearch/src/test/java/com/facebook/presto/elasticsearch/ElasticsearchQueryRunner.java
@@ -64,7 +64,7 @@ public static DistributedQueryRunner createElasticsearchQueryRunner(
             queryRunner.installPlugin(new TpchPlugin());
             queryRunner.createCatalog("tpch", "tpch");
 
-            TestingElasticsearchConnectorFactory testFactory = new TestingElasticsearchConnectorFactory();
+            ElasticsearchConnectorFactory testFactory = new ElasticsearchConnectorFactory();
 
             installElasticsearchPlugin(address, queryRunner, testFactory, extraConnectorProperties);
 
@@ -91,7 +91,7 @@ public static DistributedQueryRunner createElasticsearchQueryRunner(
     private static void installElasticsearchPlugin(
             HostAndPort address,
             QueryRunner queryRunner,
-            TestingElasticsearchConnectorFactory factory,
+            ElasticsearchConnectorFactory factory,
             Map<String, String> extraConnectorProperties)
     {
         queryRunner.installPlugin(new ElasticsearchPlugin(factory));

diff --git a/...src/test/java/com/facebook/presto/elasticsearch/TestingElasticsearchConnectorFactory.java b/...src/test/java/com/facebook/presto/elasticsearch/TestingElasticsearchConnectorFactory.java
diff --git a/presto-hive/src/main/java/com/facebook/presto/hive/HiveConnector.java b/presto-hive/src/main/java/com/facebook/presto/hive/HiveConnector.java
@@ -208,12 +208,6 @@ public ConnectorAccessControl getAccessControl()
         return accessControl;
     }
 
-    @Override
-    public boolean isSingleStatementWritesOnly()
-    {
-        return false;
-    }
-
     @Override
     public ConnectorTransactionHandle beginTransaction(IsolationLevel isolationLevel, boolean readOnly)
     {

diff --git a/presto-hive/src/main/java/com/facebook/presto/hive/pagefile/PageInputFormat.java b/presto-hive/src/main/java/com/facebook/presto/hive/pagefile/PageInputFormat.java
@@ -13,8 +13,6 @@
  */
 package com.facebook.presto.hive.pagefile;
 
-import org.apache.hadoop.fs.FileSystem;
-import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.io.NullWritable;
 import org.apache.hadoop.mapred.FileInputFormat;
 import org.apache.hadoop.mapred.InputSplit;
@@ -30,9 +28,4 @@ public RecordReader<NullWritable, NullWritable> getRecordReader(InputSplit input
     {
         throw new UnsupportedOperationException();
     }
-
-    protected boolean isSplitable(FileSystem fs, Path file)
-    {
-        return true;
-    }
 }
diff --git a/presto-hive/src/main/java/com/facebook/presto/hive/parquet/ParquetFileWriter.java b/presto-hive/src/main/java/com/facebook/presto/hive/parquet/ParquetFileWriter.java
@@ -156,12 +156,6 @@ public long getValidationCpuNanos()
         return 0;
     }
 
-    @Override
-    public Optional<Runnable> getVerificationTask()
-    {
-        return Optional.empty();
-    }
-
     @Override
     public long getFileSizeInBytes()
     {

diff --git a/.../src/test/java/com/facebook/presto/hive/TestEventListenerWithExchangeMaterialization.java b/.../src/test/java/com/facebook/presto/hive/TestEventListenerWithExchangeMaterialization.java
@@ -22,7 +22,6 @@
 import com.facebook.presto.spi.eventlistener.QueryCompletedEvent;
 import com.facebook.presto.spi.eventlistener.QueryCreatedEvent;
 import com.facebook.presto.spi.eventlistener.QueryMetadata;
-import com.facebook.presto.spi.eventlistener.SplitCompletedEvent;
 import com.facebook.presto.tests.DistributedQueryRunner;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
@@ -219,11 +218,6 @@ public void queryCompleted(QueryCompletedEvent queryCompletedEvent)
         {
             eventsBuilder.addQueryCompleted(queryCompletedEvent);
         }
-
-        @Override
-        public void splitCompleted(SplitCompletedEvent splitCompletedEvent)
-        {
-        }
     }
 
     static class EventsBuilder

diff --git a/presto-hive/src/test/java/com/facebook/presto/hive/benchmark/FileFormat.java b/presto-hive/src/test/java/com/facebook/presto/hive/benchmark/FileFormat.java
@@ -252,12 +252,6 @@ public FormatWriter createFileFormatWriter(
             }
             return new PrestoPageFormatWriter(targetFile, compressionCodec);
         }
-
-        @Override
-        public boolean supportsDate()
-        {
-            return true;
-        }
     },
 
     PRESTO_PARQUET {

diff --git a/presto-hudi/src/main/java/com/facebook/presto/hudi/HudiSplit.java b/presto-hudi/src/main/java/com/facebook/presto/hudi/HudiSplit.java
@@ -24,7 +24,6 @@
 
 import java.util.List;
 import java.util.Optional;
-import java.util.OptionalLong;
 
 import static com.facebook.presto.spi.schedule.NodeSelectionStrategy.SOFT_AFFINITY;
 import static com.google.common.base.MoreObjects.toStringHelper;
@@ -121,18 +120,6 @@ public Object getInfo()
         return this;
     }
 
-    @Override
-    public Object getSplitIdentifier()
-    {
-        return this;
-    }
-
-    @Override
-    public OptionalLong getSplitSizeInBytes()
-    {
-        return OptionalLong.empty();
-    }
-
     @JsonProperty
     @Override
     public SplitWeight getSplitWeight()

diff --git a/presto-jdbc/src/test/java/com/facebook/presto/jdbc/TestJdbcConnection.java b/presto-jdbc/src/test/java/com/facebook/presto/jdbc/TestJdbcConnection.java
@@ -339,10 +339,6 @@ public void testConnectionProperties()
     public static class TestNoopQueryInterceptor
             implements QueryInterceptor
     {
-        @Override
-        public void init(Map<String, String> properties)
-        {
-        }
     }
 
     private Connection createConnection()

diff --git a/presto-local-file/src/main/java/com/facebook/presto/localfile/LocalFileMetadata.java b/presto-local-file/src/main/java/com/facebook/presto/localfile/LocalFileMetadata.java
@@ -21,7 +21,6 @@
 import com.facebook.presto.spi.ConnectorTableLayoutHandle;
 import com.facebook.presto.spi.ConnectorTableLayoutResult;
 import com.facebook.presto.spi.ConnectorTableMetadata;
-import com.facebook.presto.spi.ConnectorViewDefinition;
 import com.facebook.presto.spi.Constraint;
 import com.facebook.presto.spi.SchemaTableName;
 import com.facebook.presto.spi.SchemaTablePrefix;
@@ -39,8 +38,6 @@
 import static com.facebook.presto.common.type.VarcharType.createUnboundedVarcharType;
 import static com.facebook.presto.localfile.LocalFileColumnHandle.SERVER_ADDRESS_COLUMN_NAME;
 import static com.facebook.presto.localfile.LocalFileColumnHandle.SERVER_ADDRESS_ORDINAL_POSITION;
-import static java.util.Collections.emptyList;
-import static java.util.Collections.emptyMap;
 import static java.util.Objects.requireNonNull;
 
 public class LocalFileMetadata
@@ -144,18 +141,6 @@ public Map<SchemaTableName, List<ColumnMetadata>> listTableColumns(ConnectorSess
         return columns.build();
     }
 
-    @Override
-    public List<SchemaTableName> listViews(ConnectorSession session, String schemaNameOrNull)
-    {
-        return emptyList();
-    }
-
-    @Override
-    public Map<SchemaTableName, ConnectorViewDefinition> getViews(ConnectorSession session, SchemaTablePrefix prefix)
-    {
-        return emptyMap();
-    }
-
     private List<SchemaTableName> listTables(ConnectorSession session, SchemaTablePrefix prefix)
     {
         if (prefix.getSchemaName() == null) {

diff --git a/presto-main/src/main/java/com/facebook/presto/server/AsyncPageTransportServlet.java b/presto-main/src/main/java/com/facebook/presto/server/AsyncPageTransportServlet.java
@@ -257,11 +257,6 @@ public void onFailure(Throwable thrown)
                 responseExecutor);
     }
 
-    @Override
-    public void destroy()
-    {
-    }
-
     @Managed
     @Nested
     public TimeStat getReadFromOutputBufferTime()

diff --git a/presto-main/src/main/java/com/facebook/presto/util/PowerOfTwoValidator.java b/presto-main/src/main/java/com/facebook/presto/util/PowerOfTwoValidator.java
@@ -19,11 +19,6 @@
 public class PowerOfTwoValidator
         implements ConstraintValidator<PowerOfTwo, Integer>
 {
-    @Override
-    public void initialize(PowerOfTwo powerOfTwo)
-    {
-    }
-
     @Override
     public boolean isValid(Integer value, ConstraintValidatorContext context)
     {

diff --git a/presto-main/src/test/java/com/facebook/presto/block/TestInt128ArrayBlock.java b/presto-main/src/test/java/com/facebook/presto/block/TestInt128ArrayBlock.java
@@ -165,12 +165,6 @@ protected boolean isAlignedLongAccessSupported()
         return true;
     }
 
-    @Override
-    protected boolean isSliceAccessSupported()
-    {
-        return true;
-    }
-
     @Override
     protected void assertSlicePosition(Block block, int position, Slice expectedSliceValue)
     {

diff --git a/presto-main/src/test/java/com/facebook/presto/block/TestShortArrayBlock.java b/presto-main/src/test/java/com/facebook/presto/block/TestShortArrayBlock.java
@@ -122,12 +122,6 @@ protected boolean isByteAccessSupported()
         return false;
     }
 
-    @Override
-    protected boolean isShortAccessSupported()
-    {
-        return true;
-    }
-
     @Override
     protected boolean isIntAccessSupported()
     {

diff --git a/presto-main/src/test/java/com/facebook/presto/execution/TestCreateTableTask.java b/presto-main/src/test/java/com/facebook/presto/execution/TestCreateTableTask.java
@@ -24,12 +24,10 @@
 import com.facebook.presto.metadata.ColumnPropertyManager;
 import com.facebook.presto.metadata.FunctionAndTypeManager;
 import com.facebook.presto.metadata.TablePropertyManager;
-import com.facebook.presto.spi.ColumnHandle;
 import com.facebook.presto.spi.ColumnMetadata;
 import com.facebook.presto.spi.ConnectorId;
 import com.facebook.presto.spi.ConnectorTableMetadata;
 import com.facebook.presto.spi.PrestoException;
-import com.facebook.presto.spi.TableHandle;
 import com.facebook.presto.spi.connector.ConnectorCapabilities;
 import com.facebook.presto.spi.constraints.TableConstraint;
 import com.facebook.presto.spi.security.AllowAllAccessControl;
@@ -317,12 +315,6 @@ public List<ConnectorTableMetadata> getReceivedTableMetadata()
             return tables;
         }
 
-        @Override
-        public void dropColumn(Session session, TableHandle tableHandle, ColumnHandle column)
-        {
-            throw new UnsupportedOperationException();
-        }
-
         @Override
         public Set<ConnectorCapabilities> getConnectorCapabilities(Session session, ConnectorId catalogName)
         {

diff --git a/presto-main/src/test/java/com/facebook/presto/operator/exchange/TestLocalExchange.java b/presto-main/src/test/java/com/facebook/presto/operator/exchange/TestLocalExchange.java
@@ -499,17 +499,6 @@ public boolean equals(Object obj)
                     }
                 }),
                 new ConnectorPartitioningHandle() {
-                    @Override
-                    public boolean isSingleNode()
-                    {
-                        return false;
-                    }
-
-                    @Override
-                    public boolean isCoordinatorOnly()
-                    {
-                        return false;
-                    }
                 });
         PartitionFunction partitionFunction = createPartitionFunction(partitioningProviderManager, session, partitioningHandle, 600, ImmutableList.of(), false);