Search name

[aminya]

Try to fix #22

This uses old JavaScript syntax. I am not sure why but it seems you want to support very old JavaScript.

[aminya]

@mafintosh I am blocked on this. If you can solve the issue it would be nice.

[mafintosh]

Unsure what is blocked and what the feature does.

[aminya]

The goal is to provide a name as the second argument, and the script searches for that package if it was not in the first argument:

var binding = require('node-gyp-build')(__dirname, "my-native-module")

[vweevers]

@aminya Can you provide an example? What is the expected directory structure?

Lack of namespacing (other than by node_modules/xyz) is a known problem (#27) but I'm not sure how this PR solves it or that it covers all cases.

[aminya]

@aminya Can you provide an example? What is the expected directory structure?

Lack of namespacing (other than by node_modules/xyz) is a known problem (#27) but I'm not sure how this PR solves it or that it covers all cases.

You can't put index.js anywhere else other than the root of the repository. Builders change the __dirname of a file when they are built. For example, the src code is written to dist.

Here is an example. Try to move index.js to src folder, set the main to dist, and build the code. Everything breaks.
https://github.com/atom-ide-community/fuzzaldrin-plus-fast

[mafintosh]

I don't think that belongs here. The node-gyp-build interface tells you to pass in the directory where the prebuilds folder is, thats the contract.

[vweevers]

Here is an example. Try to move index.js to src folder, set the main to dist, and build the code. Everything breaks.
https://github.com/atom-ide-community/fuzzaldrin-plus-fast

Simple solution: create an /index.js entry point that does module.exports = require('./dist/')(__dirname). Or in dist/index.js do path.dirname(__dirname).

I'm closing this PR seeing as it can be solved cleanly on your end, without increasing complexity here or introducing new assumptions about the directory structure.