LemmaDigital: change endpoint #3862

lm-ved · 2024-08-16T04:51:44Z

Related PR: #3750
One of them should be merged.

update bid adapter

📋 Checklist

Related pull requests in prebid.github.io are linked : [LemmaDigital] PBS parameter update prebid.github.io#5418

github-actions · 2024-08-16T04:52:30Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 08e770e

lemmadigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:35:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:74:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:110:	buildEndpointURL	100.0%
total:										(statements)		92.7%

gargcreation1992 · 2024-08-19T09:59:07Z

static/bidder-info/lemmadigital.yaml

+  iframe:
+    url: "https://sync.lemmadigital.com/js/usersync.html?redirect={{.RedirectURL}}"
+    userMacro: "${UUID}"


Usersync url is not working.

Here is an URL that I tried - https://sync.lemmadigital.com/js/usersync.html?redirect=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dlemmadigital%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%24%7BUUID%7D

@imedvedko Requesting you to please fix this usersync URL.

Looking into this

@imedvedko Requesting you to please fix this usersync URL.

It's not me 😅

@gargcreation1992 , please check now, we've made an update to the url.

UID is still not being set. Getting the following redirect URL -

https://ib.adnxs.com/prebid/setuid?bidder=lemmadigital&gdpr=&gdpr_consent=&gpp=&gpp_sid=&f=b&uid=${UUID}&

@gargcreation1992, can you share which URL you used to check this?

It worked for me:

URL used:

https://sync.lemmadigital.com/setuid?publisher=850&redirect=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dlemmadigital%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%24%7BUUID%7D

Note: The recent commit: b00e873 prior to this comment: #3862 (comment) had changed the URL.

@gargcreation1992 , did you get a chance to check this comment: #3862 (comment)?
Share the details please if there is additional feedback.

user sync verified using https://sync.lemmadigital.com/setuid?publisher=850&redirect=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3Dlemmadigital%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%24%7BUUID%7D

cookie after sync completes:

echo "eyJ0ZW1wVUlEcyI6eyJsZW1tYWRpZ2l0YWwiOnsidWlkIjoiNDUxODEwOWMtNzIwMC0xMWVmLWFjNWUtZDA4ZTc5ZjZjZjdlIiwiZXhwaXJlcyI6IjIwMjQtMDktMjdUMTU6MjA6NDAuNDkzNDYxLTA0OjAwIn19fQ" | base64 -D {"tempUIDs":{"lemmadigital":{"uid":"4518109c-7200-11ef-ac5e-d08e79f6cf7e","expires":"2024-09-27T15:20:40.493461-04:00"}}

static/bidder-info/lemmadigital.yaml

github-actions · 2024-08-22T05:58:34Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, b00e873

lemmadigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:35:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:74:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:110:	buildEndpointURL	100.0%
total:										(statements)		92.7%

bsardo · 2024-09-09T15:25:51Z

adapters/lemmadigital/lemmadigital_test.go

@@ -10,7 +10,7 @@ import (

 func TestJsonSamples(t *testing.T) {
 	bidder, buildErr := Builder(openrtb_ext.BidderLemmadigital, config.Adapter{
-		Endpoint: "https://sg.ads.lemmatechnologies.com/lemma/servad?pid={{.PublisherID}}&aid={{.AdUnit}}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
+		Endpoint: "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid={{.PublisherID}}&aid={{.AdUnit}}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})


I suggest using a fake url for your tests so that you don't have to make all of these changes to the test files if you need to change your endpoint.

@bsardo , updated the tests with a fake url to avoid future test url changes.

github-actions · 2024-09-10T05:26:57Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 637b084

lemmadigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:35:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:74:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:110:	buildEndpointURL	100.0%
total:										(statements)		92.7%

bsardo · 2024-09-13T19:24:20Z

static/bidder-info/lemmadigital.yaml

+  iframe:
+    url: "https://sync.lemmadigital.com/js/usersync.html?redirect={{.RedirectURL}}"
+    userMacro: "${UUID}"


user sync verified using https://sync.lemmadigital.com/setuid?publisher=850&redirect=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3Dlemmadigital%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%24%7BUUID%7D

cookie after sync completes:

echo "eyJ0ZW1wVUlEcyI6eyJsZW1tYWRpZ2l0YWwiOnsidWlkIjoiNDUxODEwOWMtNzIwMC0xMWVmLWFjNWUtZDA4ZTc5ZjZjZjdlIiwiZXhwaXJlcyI6IjIwMjQtMDktMjdUMTU6MjA6NDAuNDkzNDYxLTA0OjAwIn19fQ" | base64 -D {"tempUIDs":{"lemmadigital":{"uid":"4518109c-7200-11ef-ac5e-d08e79f6cf7e","expires":"2024-09-27T15:20:40.493461-04:00"}}

switched endpoint and added userSync config

08e770e

lm-ved mentioned this pull request Aug 16, 2024

LemmaDigital: add host parameter #3750

Draft

2 tasks

gargcreation1992 reviewed Aug 19, 2024

View reviewed changes

static/bidder-info/lemmadigital.yaml Show resolved Hide resolved

gargcreation1992 assigned gargcreation1992 and onkarvhanumante Aug 19, 2024

updated usersync config

b00e873

bsardo assigned przemkaczmarek and unassigned onkarvhanumante Aug 22, 2024

lm-ved requested a review from gargcreation1992 August 23, 2024 05:02

bsardo reviewed Sep 9, 2024

View reviewed changes

updated test url to avoid future changes in multiple files

637b084

lm-ved requested a review from bsardo September 10, 2024 05:26

bsardo approved these changes Sep 13, 2024

View reviewed changes

bsardo assigned bsardo and unassigned przemkaczmarek Sep 13, 2024

gargcreation1992 approved these changes Sep 16, 2024

View reviewed changes

gargcreation1992 merged commit 640b97c into prebid:master Sep 16, 2024
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Sep 16, 2024

Port PR from PBS-Go: LemmaDigital: change endpoint prebid/prebid-server-java#3444

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LemmaDigital: change endpoint #3862

LemmaDigital: change endpoint #3862

lm-ved commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

gargcreation1992 Aug 19, 2024

gargcreation1992 Aug 19, 2024

gargcreation1992 Aug 21, 2024

lm-ved Aug 21, 2024

imedvedko Aug 21, 2024

lm-ved Aug 22, 2024

gargcreation1992 Aug 27, 2024

lm-ved Aug 27, 2024 •

edited

Loading

lm-ved Aug 29, 2024

bsardo Sep 13, 2024

github-actions bot commented Aug 22, 2024

bsardo Sep 9, 2024

lm-ved Sep 10, 2024

github-actions bot commented Sep 10, 2024

bsardo Sep 13, 2024

LemmaDigital: change endpoint #3862

LemmaDigital: change endpoint #3862

Conversation

lm-ved commented Aug 16, 2024

📋 Checklist

github-actions bot commented Aug 16, 2024

Code coverage summary

lemmadigital

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lm-ved Aug 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 22, 2024

Code coverage summary

lemmadigital

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 10, 2024

Code coverage summary

lemmadigital

Choose a reason for hiding this comment

lm-ved Aug 27, 2024 •

edited

Loading