New Adapter: Missena #3761

ysfbsf · 2024-06-18T13:35:05Z

Related Documentation: prebid/prebid.github.io#5437

github-actions · 2024-06-18T13:35:55Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4d210b9

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/missena/missena.go:55:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:62:	makeParameter	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:76:	makeRequest	83.3%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:113:	MakeRequests	96.3%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:162:	readGDPR	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:182:	MakeBids	94.4%
total:									(statements)	93.7%

przemkaczmarek · 2024-07-26T11:25:02Z

static/bidder-info/missena.yaml

@@ -0,0 +1,16 @@
+endpoint: https://bid.missena.io/
+maintainer:
+  email: yboussafa@missena.com


this looks like a private email, please enter maintenance email

przemkaczmarek · 2024-07-31T13:40:54Z

static/bidder-params/missena.json

+  "properties": {
+    "apiKey": {
+      "type": "string",
+      "description": "API Key"


You have to add "minimum": 1

You should only add this if you don't want to accept an apiKey of zero length.

przemkaczmarek · 2024-07-31T13:43:17Z

adapters/missena/params_test.go

+}
+
+var validParams = []string{
+	`{"apiKey": ""}`,


when You add "minimum": 1 to missena.json add this example to ivalidParams

przemkaczmarek · 2024-07-31T13:45:36Z

adapters/missena/missena.go

+		if request.Device.IP != "" {
+			headers.Add("X-Forwarded-For", request.Device.IP)
+		} else if request.Device.IPv6 != "" {
+			headers.Add("X-Forwarded-For", request.Device.IPv6)


add test for it.

bsardo · 2024-08-30T19:58:42Z

static/bidder-params/missena.json

+  "properties": {
+    "apiKey": {
+      "type": "string",
+      "description": "API Key"


You should only add this if you don't want to accept an apiKey of zero length.

bsardo · 2024-08-30T20:01:09Z

static/bidder-info/missena.yaml

@@ -0,0 +1,16 @@
+endpoint: https://bid.missena.io/


Endpoint is reachable

curl -i --location --request POST https://bid.missena.io/ HTTP/1.1 403 Forbidden Date: Fri, 30 Aug 2024 20:00:07 GMT Content-Type: text/plain; charset=utf-8 Content-Length: 9 Connection: keep-alive Vary: Origin Forbidden

@bsardo The endpoint is only accessible by calling it with a valid API Key. Example:

curl --location 'https://bid.staging.missena.xyz/?t=PA-34761163' \ --header 'Accept: */*' \ --header 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \ --header 'Cache-Control: no-cache' \ --header 'Connection: keep-alive' \ --header 'Origin: https://publisher.staging.missena.click' \ --header 'Pragma: no-cache' \ --header 'Referer: https://publisher.staging.missena.click/' \ --header 'Sec-Browsing-Topics: ();p=P0000000000000000000000000000000' \ --header 'Sec-Fetch-Dest: empty' \ --header 'Sec-Fetch-Mode: cors' \ --header 'Sec-Fetch-Site: cross-site' \ --header 'User-Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 16_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Mobile/15E148 Safari/604.1' \ --header 'content-type: text/plain' \ --data '{ "adunit": "msna-sticky-dd", "request_id": "53dfce8e0aad03", "test": "smart-banner", "placement": "sticky" }'

All good @ysfbsf. All I'm doing here is proving that I can reach your endpoint and sharing that proof with other reviewers. No action required.

bsardo · 2024-08-30T20:02:19Z

static/bidder-info/missena.yaml

+endpoint: https://bid.missena.io/
+maintainer:
+  email: yboussafa@missena.com
+gvlVendorID: 687


verified GVL ID:

curl https://vendor-list.consensu.org/v3/vendor-list.json | jq '.vendors."687"' % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 628k 100 628k 0 0 3635k 0 --:--:-- --:--:-- --:--:-- 3655k { "id": 687, "name": "MISSENA", "purposes": [ 1, 2, 3, 4, 5, 6, 7 ], "legIntPurposes": [], "flexiblePurposes": [], "specialPurposes": [ 2 ], "features": [ 2, 3 ], "specialFeatures": [], "cookieMaxAgeSeconds": 31104000, "usesCookies": true, "cookieRefresh": true, "usesNonCookieAccess": true, "dataRetention": { "stdRetention": 360, "purposes": {}, "specialPurposes": {} }, "urls": [ { "langId": "en", "privacy": "https://missena.com/privacy", "legIntClaim": "https://missena.com/privacy" } ], "dataDeclaration": [ 1, 2, 3, 4, 5, 6, 7, 8, 10 ], "deviceStorageDisclosureUrl": "https://ad.missena.io/iab.json" }

@bsardo Do you mean that no need to provide the GVL ID since it's a verified one?

Sorry for the confusion @ysfbsf. No action is required here; you should continue to specify the GVL ID. My comment is just proof to other reviewers that I verified the GVL ID you specified is associated with your bidder.

bsardo · 2024-08-30T21:17:12Z

adapters/missena/params_test.go

+var invalidParams = []string{
+	`{"apiKey": 42}`,
+	`{"placement": 111}`,
+}


I suggest adding the following test cases:

placement is valid but apiKey is omitted since it is required

apiKey is valid but placement is not

bsardo · 2024-08-30T21:18:58Z

adapters/missena/missena_test.go

+
+func TestJsonSamples(t *testing.T) {
+	bidder, buildErr := Builder(openrtb_ext.BidderMissena, config.Adapter{
+		Endpoint: "https://bid.missena.io"},


I recommend using a fake URL for your endpoint to minimize maintenance should you ever change your production endpoint.

bsardo · 2024-08-30T21:51:30Z

adapters/missena/missena.go

+	var tempErrors []error
+	gdprApplies, consentString := readGDPR(request)
+
+	var missenaInternalParams MissenaInternalParams


Nitpick: you could combine this with the gdpr field assignments on lines 144-145 as:

missenaInternalParams := MissenaInternalParams{ GDPR: gdprApplies, GDPRConsent: consentString, }

bsardo · 2024-08-30T22:01:35Z

adapters/missena/missena.go

+	} else if newHttpRequest != nil {
+		httpRequests = append(httpRequests, newHttpRequest)
+	}
+
+	return httpRequests, finalErrors


Do you need the else if? You could probably just do:

httpRequests = append(httpRequests, newHttpRequest) return httpRequests, errors

bsardo · 2024-08-30T22:04:17Z

adapters/missena/missena.go

+	var errors []error
+	return bidResponse, errors


Simplify to return bidResponse, nil

bsardo · 2024-08-30T22:10:24Z

adapters/missena/missena.go

+
+	var missenaInternalParams MissenaInternalParams
+
+	for _, imp := range request.Imp {


It appears you are prepared to handle multiple imps but really you only care that at least one of them is valid as you're just preparing a single request without specifying the impression ID, though you are grabbing the params from the last imp you process. Is this what you want or do you want to grab the info from the first imp?

I suggest adding a test where there are multiple imps with different params, specifically placement. I also think you should add a test where one imp results in an error and the other is well formed.

bsardo · 2024-08-30T22:13:55Z

adapters/missena/missena.go

+		Uri:     url,
+		Headers: headers,
+		Body:    body,
+		ImpIDs:  openrtb_ext.GetImpIDs(request.Imp),


If you're only sending a bid request to your server for one imp, that imp is the one that should be specified here rather than specifying all of the imps.

github-actions · 2024-09-15T14:10:47Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8c79b48

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/missena/missena.go:55:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:62:	makeParameter	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:76:	makeRequest	94.4%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:113:	MakeRequests	88.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:166:	readGDPR	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:186:	MakeBids	94.1%
total:									(statements)	93.4%

bsardo · 2024-09-16T17:36:36Z

static/bidder-info/missena.yaml

@@ -0,0 +1,16 @@
+endpoint: https://bid.missena.io/
+maintainer:
+  email: prebid@missena.com


We've sent a test email to prebid@missena.com. Please respond to the email with a message of "received".

@bsardo Can you send the email again?

@ysfbsf Sent

bsardo · 2024-09-16T17:47:23Z

static/bidder-info/missena.yaml

+userSync:
+  redirect:
+    url: https://sync.missena.io/iframe?gdpr={{.GDPR}}&consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}
+    userMacro: $UID


Is this working correctly? I didn't see the redirect to the PBS setuid endpoint with the missena user ID so that it can be set on the PBS cookie.

This does not appear to be working. Two things:

I see iframe in your URL which leads me to believe your user sync is of type iframe instead of redirect. If that's the case, you should indicate as such:

userSync: iframe: url: ... userMacro: $UID

When I initiate a user sync I do not see the redirect to the PBS setuid endpoint, which will be specified in the redirect portion of your user sync query string (redirect={{.RedirectURL}}). This is where your user ID is set on the PBS cookie.

bsardo · 2024-09-16T18:07:00Z

adapters/missena/missenatest/exemplary/ipv6.json

Please move this test under the supplemental folder or rename to simple-banner-ipv6.json.

bsardo · 2024-09-16T18:13:28Z

adapters/missena/missenatest/exemplary/multiple-imps.json

You might want to consider adding a third imp to this test so that two imps are valid and one is invalid. That would make the intended behavior clear for when there are multiple valid imps.

bsardo · 2024-09-16T18:21:37Z

adapters/missena/missena.go

+	if len(httpRequests) == 0 && len(errors) == 0 {
+		errors = append(errors, &errortypes.BadInput{
+			Message: "No valid impressions found",
+		})
+	}


I think you can delete this if block. The only time this condition would be true is if the bid request does not contain any imps but the code upstream will validate that there is at least one impression before calling your adapter.

bsardo · 2024-09-16T18:24:01Z

adapters/missena/missena.go

+	return &missenaRequest
+}
+
+func (a *adapter) makeRequest(missenaParams MissenaInternalParams, reqInfo *adapters.ExtraRequestInfo, imp *openrtb2.Imp, request *openrtb2.BidRequest) (*adapters.RequestData, error) {


Nitpick: instead of passing a pointer to the imp, I suggest just passing the imp ID as a string to keep things simple since that's the only field you're using on the impression.

bsardo · 2024-09-16T18:27:11Z

adapters/missena/missena.go

+func (a *adapter) makeRequest(missenaParams MissenaInternalParams, reqInfo *adapters.ExtraRequestInfo, imp *openrtb2.Imp, request *openrtb2.BidRequest) (*adapters.RequestData, error) {
+
+	url := a.endpoint + "?t=" + missenaParams.ApiKey
+	parameter := a.makeParameter(missenaParams, request)


You could simplify your adapter a bit eliminating a function call by deleting the makeParameter function and moving that function's contents in line so that you construct the MissenaAdRequest instance here.

bsardo · 2024-09-16T18:28:12Z

adapters/missena/missena.go

+	if request.Device != nil {
+		headers.Add("User-Agent", request.Device.UA)
+	}
+
+	if request.Device != nil {


Nitpick: you can simplify your logic by getting rid of the first device nil check and instead moving headers.Add("User-Agent", request.Device.UA) into the second device nil check.

bsardo · 2024-09-16T18:28:35Z

adapters/missena/missena.go

+}
+
+func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
+	// print the request


Delete comment

bsardo · 2024-09-16T18:31:24Z

adapters/missena/missena.go

+			consentString = extUser.Consent
+		}
+	}
+	gdprApplies := true


Just checking, are you sure you always want to default to gdpr applies if no gdpr signal has been provided? Perhaps a supplemental test should be added for when gdpr is not set.

github-actions · 2024-09-18T12:01:54Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 00993a5

missena

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/missena/missena.go:55:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:62:	makeRequest	94.1%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:106:	MakeRequests	91.3%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:152:	readGDPR	100.0%
github.com/prebid/prebid-server/v2/adapters/missena/missena.go:172:	MakeBids	94.1%
total:									(statements)	94.4%

bsardo

LGTM except for the user sync.

bsardo · 2024-09-20T13:36:32Z

static/bidder-info/missena.yaml

+userSync:
+  redirect:
+    url: https://sync.missena.io/iframe?gdpr={{.GDPR}}&consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}
+    userMacro: $UID


This does not appear to be working. Two things:

I see iframe in your URL which leads me to believe your user sync is of type iframe instead of redirect. If that's the case, you should indicate as such:

userSync: iframe: url: ... userMacro: $UID

When I initiate a user sync I do not see the redirect to the PBS setuid endpoint, which will be specified in the redirect portion of your user sync query string (redirect={{.RedirectURL}}). This is where your user ID is set on the PBS cookie.

New Adapter: Missena

4d210b9

ysfbsf mentioned this pull request Jun 18, 2024

New Prebid Server Adapter: Missena prebid/prebid.github.io#5437

Open

3 tasks

bsardo assigned przemkaczmarek and bsardo Jul 24, 2024

przemkaczmarek reviewed Jul 26, 2024

View reviewed changes

przemkaczmarek reviewed Jul 31, 2024

View reviewed changes

bsardo reviewed Aug 30, 2024

View reviewed changes

New Adapter: Missena - Updated

8c79b48

ysfbsf requested review from bsardo and przemkaczmarek September 15, 2024 14:31

bsardo reviewed Sep 16, 2024

View reviewed changes

Code cleaning

00993a5

bsardo reviewed Sep 20, 2024

View reviewed changes


		var missenaInternalParams MissenaInternalParams

		for _, imp := range request.Imp {

New Adapter: Missena #3761

Are you sure you want to change the base?

New Adapter: Missena #3761

Conversation

ysfbsf commented Jun 18, 2024

github-actions bot commented Jun 18, 2024

Code coverage summary

missena

Choose a reason for hiding this comment

Choose a reason for hiding this comment

przemkaczmarek Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 15, 2024

Code coverage summary

missena

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 18, 2024

Code coverage summary

missena

bsardo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

przemkaczmarek Jul 31, 2024 •

edited

Loading