Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Team ID #77

Closed
bretg opened this issue Sep 23, 2021 · 3 comments
Closed

Support Team ID #77

bretg opened this issue Sep 23, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request in DEV Resolution is in DEV release

Comments

@bretg
Copy link

bretg commented Sep 23, 2021

  • line-item-manager version: all
  • Python version: any
  • Operating System: any

Description

Customers who use the premium version of GAM can utilize the "teams" feature. When that happens, Orders must be created with the "appliedTeamIds" field listing which teams have access to that order.

If the service account has a team, then the orders must be created with that appliedTeamId or the order won't run.

Proposal: support an optional "appliedTeamIds" field in the YAML file. e.g.

###############################################################################
# Orders (required)
# Allowed Templating Key Words: Bidder, Media, Order, Misc
###############################################################################
order:
  name: "Prebid-{{ bidder_name }}-{{ media_type }}-{{ time }} {{ cpm_min }}-{{ cpm_max }}"
  appliedTeamIds: 
     - 101
     - 555
     - 234567

(Note: my YAML is sketchy - whatever's the best way to represent an array of long ints)

If specified, add the appliedTeamIds argument to the Orders request made to the GAM API.

@bretg bretg added the enhancement New feature or request label Sep 23, 2021
@dshore
Copy link
Collaborator

dshore commented Sep 23, 2021

@bretg Is it important that the team ids are validated (I would assume by checking the GAM Team service)? Or is the assumption that they do exist acceptable?

@dshore dshore self-assigned this Sep 23, 2021
@bretg
Copy link
Author

bretg commented Sep 23, 2021

I'd suggest letting GAM throw errors if the values supplied aren't valid.

@dshore
Copy link
Collaborator

dshore commented Sep 26, 2021

@bretg This is now available to test as a dev release:

$ pip uninstall line-item-manager
$ pip install https://github.com/prebid/line-item-manager/archive/master.zip
$ line_item_manager --version
line-item-manager version 0.2.3-dev1

You should see the above version after installing from master.

dshore added a commit that referenced this issue Sep 26, 2021
Support for appliedTeamIds in Orders (#77)
@dshore dshore added the in DEV Resolution is in DEV release label Sep 27, 2021
@dshore dshore closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in DEV Resolution is in DEV release
Projects
None yet
Development

No branches or pull requests

2 participants