Preciso : Added new library to remove code duplication in bid adapter #11868

NikhilGopalChennissery · 2024-06-26T11:27:30Z

Type of change

Description of change

Other information

patmmccann · 2024-06-26T17:09:51Z

This still contains a bunch of tricks to avoid the report. Duplication still exists between Preciso utils and redtram and idx and mediabramaBidAdapter

      "fragment": "}\n\nfunction getBidFloor(bid) {\n  if (!isFn(bid.getFloor)) {\n    return deepAccess(bid, 'params.bidFloor', 0);\n  }\n\n  try {\n    const bidFloor = bid.getFloor({\n      currency: 'USD',\n      mediaType: '*',\n      size: '*',\n    });\n    return bidFloor.floor;\n  } catch (_) {\n    return 0\n  }\n}\n\nregisterBidder",

patmmccann · 2024-06-26T17:12:54Z

This feels like a hostile attempt to circumvent our guidelines

… into master_jun_24

NikhilGopalChennissery · 2024-06-27T07:05:26Z

hi @patmmccann, thank you for updating me.

we have changed bidfloor mapping logic in our library.

Thank You

patmmccann · 2024-06-27T13:35:37Z

Your pr is not yet reducing code duplication because it does not modify the redtram and idx bid adapters to import the library code

NikhilGopalChennissery · 2024-06-28T05:00:02Z

Hi @patmmccann,

Do you mean that we need to modify the idx and redtram bid adapters? Do we have permission to change other adapters' code?

If we have permission to change other organizations' bidder adapters, we will import the library into those adapters as well.

As you suggested, we created a new library with the required functionality and modified the duplicated functionality. We then imported that library into our adapter to use its functionality.

I couldn't see any duplication in the library we created with other adapters.

Please correct me if I am wrong.

Thank you.

patmmccann · 2024-06-28T10:42:01Z

Yes, in the main branch you have duplication with those adapters, the goal of this to effort is to import common functions into all three.

github-actions · 2024-07-24T11:29:00Z

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

libraries/precisoUtils/precisoUtils.js (+1 error)
modules/precisoBidAdapter.js (+1 error)

github-actions · 2024-07-24T11:51:51Z

Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):

libraries/precisoUtils/precisoUtils.js (+4 errors)
modules/precisoBidAdapter.js (+2 errors)

github-actions · 2024-08-06T07:35:31Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/mediabramaBidAdapter.js has 56 duplicated lines with modules/redtramBidAdapter.js
modules/mediabramaBidAdapter.js has 46 duplicated lines with modules/redtramBidAdapter.js
modules/loganBidAdapter.js has 49 duplicated lines with modules/redtramBidAdapter.js
modules/edge226BidAdapter.js has 24 duplicated lines with modules/redtramBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2024-08-08T08:10:02Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/loganBidAdapter.js has 18 duplicated lines with libraries/bidUtils/bidUtilsCommon.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

… into master_jun_24

NikhilGopalChennissery · 2024-08-09T06:24:19Z

Hi @patmmccann,

I have imported and used a common library in all four adapters to remove the code duplication. Could you please check it when you have time?

Thank you.

libraries/bidUtils/bidUtils.js

libraries/bidUtils/bidUtilsCommon.js

patmmccann · 2024-08-12T14:22:44Z

Looking pretty good! almost at the finish line, some comments in slack

NikhilGopalChennissery · 2024-08-12T18:08:58Z

Hi @patmmccann ,Thank you for your guidance.

I have made the changes.

Thanks a lot!

patmmccann

code looks good, please dont modify the renderer.js files

patmmccann · 2024-08-14T18:24:39Z

libraries/creative-renderer-display/renderer.js

lgtm, just undo your changes to this file and the below, these should be autogenerated and not modified by your pr

ooh sorry . I have reverted that changes.

NikhilGopalChennissery · 2024-08-16T06:55:19Z

code looks good, please dont modify the renderer.js files

Ooh sorry. I have reverted that changes.

Thank You!

openxBidAdapter remove PAF, bugfix ortbConverter response (prebid#12105) Appnexus Bid Adapter: fix parse of the encoded string to check for ast_override_div argument (prebid#12106) Richaudience Bid Adapter : add compability with DSA (prebid#12099) * Update richaudienceBidAdapter.md Update maintainer e-mail to integrations@richaudience.com * Add richaudienceBidAdapter.js file * Add richaudienceBidAdapter_spec.js * Update richaudienceBidAdapter.js * RichaudienceBidAdapter add compability with DSA * RichaudienceBidAdapter add compability with DSA * RichaudienceBidAdapter add compability with DSA --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com> Co-authored-by: sergigimenez <sergi.gim@gmail.com> finish unit testing added container identifier for viewability on bid params Add new TGM adapter (prebid#12100) Co-authored-by: apykhteyev <alex@project-limelight.com> Prebid 9.9.0 release Increment version to 9.10.0-pre deprecate old copper6 alias (prebid#12112) LimelightDigital Adapter: Add support of ortb2 and ortb2Imp objects (prebid#12078) * Add support of ortb2 and ortb2Imp objects * Fix tests * Fix tests --------- Co-authored-by: apykhteyev <alex@project-limelight.com> update configuration example (prebid#12109) FPD Enrichment: Replace device values `w` and `h` with screen size; add `ext.vpw` and `ext.vph` (prebid#12108) Core: fix broken native resizing (prebid#12096) * Core: fix broken native resizing * fix test Weborama RTD Module: BUGFIX on user-centric profile validation (prebid#12095) * update unit tests * fix code and doc * improve integration example * add extra test * improve logging * fix lint issues hotfix - after this I will fix all tests fix fix width and height fix iframe detection change detected viewability between 0 and 1 to be consistent with declared viewability improve the case case where the publisher doesn't send us a container id to check viewability fully covered by tests fix test that works local re-use percentInView method fix unit tests removed test Revert "removed test" This reverts commit 15dcab7. Anyclip Bid Adapter : refactor bid adapter (prebid#12030) * update anyclip adapter * remove coppa * fix jsdoc warnings * create bidderUtils * delete duplicate code * refactor --------- Co-authored-by: Chucky-choo <dedafu47@gmail.com> Digital Matter Bid Adapter: initial release (prebid#12114) * update anyclip adapter * remove coppa * fix jsdoc warnings * create bidderUtils * delete duplicate code * refactor * add digitalMatter Bid Adapter --------- Co-authored-by: Chucky-choo <dedafu47@gmail.com> IX Bid Adapter: Remove client FT pbjs_allow_all_eids (prebid#12117) Co-authored-by: Sajid Mahmood <sajid.mahmood@indexexchange.com> SeedingAlliance Adapter: rework to properly use openRTB standard internally (prebid#12101) * rework adapter to only use openRTB data internally * added comments * fix lint errors saambaaBidAdapter.js: make alias of advangelist (prebid#11992) * saambaaBidAdapter.js: reuse repeated code block * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Create index.js * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Update index.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update index.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update index.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Delete modules/saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Update beachfrontBidAdapter.js * Update beachfrontBidAdapter.js * Update beachfrontBidAdapter.js * Update nextrollBidAdapter.js * Update beachfrontBidAdapter.js * Update index.js * Update advangelistsBidAdapter.js * Update beachfrontBidAdapter.js * Create saambaaBidAdapter.js * fix file name --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Prebid 9.10.0 release Increment version to 9.11.0-pre Core: make sure adUnitCodes are unique in auction events (prebid#12127) Mobian RTD provider: update API endpoint (prebid#12121) * update API endpoint for mobian RTD provider * lint mobian RTD provider Initial Commit for Symitri Analytics Adapter (prebid#12132) Co-authored-by: Manan <manan.patel@intersection.com> Djax Bid Adapter : initial release (prebid#12120) * Djax bid adapter files added * fix linting issue * Linting issue fixed * Update djaxBidAdapter.js * Update djaxBidAdapter_spec.js * Update djaxBidAdapter_spec.js --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Patrick McCann <pmccann@cafemedia.com> Preciso : Added new library to remove code duplication in bid adapter (prebid#11868) * Preciso : Added new library to remove code duplication in bid adapter * modified bidfloor mapping logic * error fix * error fix * import bidUtils.js in IdxBidadapter to reduce the code duplicataion * import bidUtils.js in IdxBidadapter to reduce the code duplicataion * Error fix * Imported bidUtils library into redtram bid adapter * import common library in mediabramaBidAdapter * import common library in loganBidAdapter to remove code duplication * removed storageManaser from library * renderer.js changes reverted 33across - allow aliasing (prebid#12138) Updating isBidRequestValid logic to account for aliasing of bidder names (prebid#12136) Digitalmatter Bid Adapter : add dichange alias (prebid#12133) * add alias * fix alias --------- Co-authored-by: Chucky-choo <dedafu47@gmail.com> add media consortium adapter (prebid#11892) Co-authored-by: Maxime Lequain <maxime.lequain@gmail.com> UserID: merge EIDs with first party data (prebid#12110) * ortbConverter: do not override EIDS provided as first party data * update tests * Allow bidder-specific FPD enrichments * Refactor eid generation, add primaryIds * EIDs as FPD * Fix tests * PBS tests, fix multiple hook registration * Fix more test cleanup * remove eidPermissions * refactor oderByPriority * refactor initializedSubmodules * fix lint * update id5 primaryIds * simplify eid source filtering * clean up PBS userId logic * Revert "Allow bidder-specific FPD enrichments" This reverts commit 2fb7452. * undo bidder-specific enrichments * use startAuction instead of requestBids * add test on userIdAsEids * Fix lint Bump ws, @wdio/browserstack-service, @wdio/cli and @wdio/local-runner (prebid#12148) Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependencies [ws](https://github.com/websockets/ws), [@wdio/browserstack-service](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-browserstack-service), [@wdio/cli](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-cli) and [@wdio/local-runner](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-local-runner). These dependencies need to be updated together. Updates `ws` from 8.13.0 to 8.17.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.13.0...8.17.1) Updates `@wdio/browserstack-service` from 8.39.0 to 9.0.5 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-browserstack-service) Updates `@wdio/cli` from 8.39.0 to 9.0.5 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-cli) Updates `@wdio/local-runner` from 8.39.0 to 9.0.5 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-local-runner) --- updated-dependencies: - dependency-name: ws dependency-type: indirect - dependency-name: "@wdio/browserstack-service" dependency-type: direct:development - dependency-name: "@wdio/cli" dependency-type: direct:development - dependency-name: "@wdio/local-runner" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Smartadserver Bid Adapter : add DSA support (prebid#12141) * add support of dsa * restore topics * DSA fix for UT Change consent default param name (prebid#12154) Co-authored-by: Danijel Ristic <danijel-ristic@target-video.com> Freedom Ad Network Bid Adapter: initial release (prebid#12153) * Create fanAdapter.md * Create fanAdapter.js * Create fanAdapter_spec.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter.js deleted bidder name check (prebid#12157) Co-authored-by: Octavia Suceava <octaviasuceava@Octavias-MacBook-Pro.local> Connatix Bid Adapter : support eids (prebid#12142) * add eids on request * change naming --------- Co-authored-by: Darian Avasan <darian.avasan@connatix.com> Co-authored-by: Octavia Suceava <octaviasuceava@Octavias-MacBook-Pro.local> PrebidServer Bid Adapter : update to use gloablly defined alias or s2sConfig defined alias (prebid#12159) * update to use gloablly defined alias or s2sConfig defined alias * Add test case --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

* implement viewability support openxBidAdapter remove PAF, bugfix ortbConverter response (#12105) Appnexus Bid Adapter: fix parse of the encoded string to check for ast_override_div argument (#12106) Richaudience Bid Adapter : add compability with DSA (#12099) * Update richaudienceBidAdapter.md Update maintainer e-mail to integrations@richaudience.com * Add richaudienceBidAdapter.js file * Add richaudienceBidAdapter_spec.js * Update richaudienceBidAdapter.js * RichaudienceBidAdapter add compability with DSA * RichaudienceBidAdapter add compability with DSA * RichaudienceBidAdapter add compability with DSA --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com> Co-authored-by: sergigimenez <sergi.gim@gmail.com> finish unit testing added container identifier for viewability on bid params Add new TGM adapter (#12100) Co-authored-by: apykhteyev <alex@project-limelight.com> Prebid 9.9.0 release Increment version to 9.10.0-pre deprecate old copper6 alias (#12112) LimelightDigital Adapter: Add support of ortb2 and ortb2Imp objects (#12078) * Add support of ortb2 and ortb2Imp objects * Fix tests * Fix tests --------- Co-authored-by: apykhteyev <alex@project-limelight.com> update configuration example (#12109) FPD Enrichment: Replace device values `w` and `h` with screen size; add `ext.vpw` and `ext.vph` (#12108) Core: fix broken native resizing (#12096) * Core: fix broken native resizing * fix test Weborama RTD Module: BUGFIX on user-centric profile validation (#12095) * update unit tests * fix code and doc * improve integration example * add extra test * improve logging * fix lint issues hotfix - after this I will fix all tests fix fix width and height fix iframe detection change detected viewability between 0 and 1 to be consistent with declared viewability improve the case case where the publisher doesn't send us a container id to check viewability fully covered by tests fix test that works local re-use percentInView method fix unit tests removed test Revert "removed test" This reverts commit 15dcab7. Anyclip Bid Adapter : refactor bid adapter (#12030) * update anyclip adapter * remove coppa * fix jsdoc warnings * create bidderUtils * delete duplicate code * refactor --------- Co-authored-by: Chucky-choo <dedafu47@gmail.com> Digital Matter Bid Adapter: initial release (#12114) * update anyclip adapter * remove coppa * fix jsdoc warnings * create bidderUtils * delete duplicate code * refactor * add digitalMatter Bid Adapter --------- Co-authored-by: Chucky-choo <dedafu47@gmail.com> IX Bid Adapter: Remove client FT pbjs_allow_all_eids (#12117) Co-authored-by: Sajid Mahmood <sajid.mahmood@indexexchange.com> SeedingAlliance Adapter: rework to properly use openRTB standard internally (#12101) * rework adapter to only use openRTB data internally * added comments * fix lint errors saambaaBidAdapter.js: make alias of advangelist (#11992) * saambaaBidAdapter.js: reuse repeated code block * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Create index.js * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Update index.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update index.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update index.js * Update advangelistsBidAdapter.js * Update saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Delete modules/saambaaBidAdapter.js * Update advangelistsBidAdapter.js * Update beachfrontBidAdapter.js * Update beachfrontBidAdapter.js * Update beachfrontBidAdapter.js * Update nextrollBidAdapter.js * Update beachfrontBidAdapter.js * Update index.js * Update advangelistsBidAdapter.js * Update beachfrontBidAdapter.js * Create saambaaBidAdapter.js * fix file name --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Prebid 9.10.0 release Increment version to 9.11.0-pre Core: make sure adUnitCodes are unique in auction events (#12127) Mobian RTD provider: update API endpoint (#12121) * update API endpoint for mobian RTD provider * lint mobian RTD provider Initial Commit for Symitri Analytics Adapter (#12132) Co-authored-by: Manan <manan.patel@intersection.com> Djax Bid Adapter : initial release (#12120) * Djax bid adapter files added * fix linting issue * Linting issue fixed * Update djaxBidAdapter.js * Update djaxBidAdapter_spec.js * Update djaxBidAdapter_spec.js --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Patrick McCann <pmccann@cafemedia.com> Preciso : Added new library to remove code duplication in bid adapter (#11868) * Preciso : Added new library to remove code duplication in bid adapter * modified bidfloor mapping logic * error fix * error fix * import bidUtils.js in IdxBidadapter to reduce the code duplicataion * import bidUtils.js in IdxBidadapter to reduce the code duplicataion * Error fix * Imported bidUtils library into redtram bid adapter * import common library in mediabramaBidAdapter * import common library in loganBidAdapter to remove code duplication * removed storageManaser from library * renderer.js changes reverted 33across - allow aliasing (#12138) Updating isBidRequestValid logic to account for aliasing of bidder names (#12136) Digitalmatter Bid Adapter : add dichange alias (#12133) * add alias * fix alias --------- Co-authored-by: Chucky-choo <dedafu47@gmail.com> add media consortium adapter (#11892) Co-authored-by: Maxime Lequain <maxime.lequain@gmail.com> UserID: merge EIDs with first party data (#12110) * ortbConverter: do not override EIDS provided as first party data * update tests * Allow bidder-specific FPD enrichments * Refactor eid generation, add primaryIds * EIDs as FPD * Fix tests * PBS tests, fix multiple hook registration * Fix more test cleanup * remove eidPermissions * refactor oderByPriority * refactor initializedSubmodules * fix lint * update id5 primaryIds * simplify eid source filtering * clean up PBS userId logic * Revert "Allow bidder-specific FPD enrichments" This reverts commit 2fb7452. * undo bidder-specific enrichments * use startAuction instead of requestBids * add test on userIdAsEids * Fix lint Bump ws, @wdio/browserstack-service, @wdio/cli and @wdio/local-runner (#12148) Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependencies [ws](https://github.com/websockets/ws), [@wdio/browserstack-service](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-browserstack-service), [@wdio/cli](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-cli) and [@wdio/local-runner](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-local-runner). These dependencies need to be updated together. Updates `ws` from 8.13.0 to 8.17.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.13.0...8.17.1) Updates `@wdio/browserstack-service` from 8.39.0 to 9.0.5 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-browserstack-service) Updates `@wdio/cli` from 8.39.0 to 9.0.5 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-cli) Updates `@wdio/local-runner` from 8.39.0 to 9.0.5 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.5/packages/wdio-local-runner) --- updated-dependencies: - dependency-name: ws dependency-type: indirect - dependency-name: "@wdio/browserstack-service" dependency-type: direct:development - dependency-name: "@wdio/cli" dependency-type: direct:development - dependency-name: "@wdio/local-runner" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Smartadserver Bid Adapter : add DSA support (#12141) * add support of dsa * restore topics * DSA fix for UT Change consent default param name (#12154) Co-authored-by: Danijel Ristic <danijel-ristic@target-video.com> Freedom Ad Network Bid Adapter: initial release (#12153) * Create fanAdapter.md * Create fanAdapter.js * Create fanAdapter_spec.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter_spec.js * Update fanAdapter.js * Update fanAdapter.js deleted bidder name check (#12157) Co-authored-by: Octavia Suceava <octaviasuceava@Octavias-MacBook-Pro.local> Connatix Bid Adapter : support eids (#12142) * add eids on request * change naming --------- Co-authored-by: Darian Avasan <darian.avasan@connatix.com> Co-authored-by: Octavia Suceava <octaviasuceava@Octavias-MacBook-Pro.local> PrebidServer Bid Adapter : update to use gloablly defined alias or s2sConfig defined alias (#12159) * update to use gloablly defined alias or s2sConfig defined alias * Add test case --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * fix build * test if can fix * Revert "test if can fix" This reverts commit 221f612. * remove test * refactoring --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

NikhilGopalChennissery and others added 2 commits June 26, 2024 16:56

Preciso : Added new library to remove code duplication in bid adapter

17451f8

Merge branch 'prebid:master' into master_jun_24

c8f17b7

NikhilGopalChennissery mentioned this pull request Jun 26, 2024

Preciso Bid Adapter : update on valid request checks #11745

Closed

10 tasks

NikhilGopalChennissery and others added 3 commits June 27, 2024 11:43

modified bidfloor mapping logic

23731e6

Merge branch 'master_jun_24' of https://github.com/PrecisoSRL/Prebid.js…

3db9592

… into master_jun_24

Merge branch 'prebid:master' into master_jun_24

ec467a9

ChrisHuie added feature labels Jul 2, 2024

patmmccann added maintenance and removed feature labels Jul 17, 2024

Merge branch 'prebid:master' into master_jun_24

b60e3d6

error fix

1e51330

NikhilGopalChennissery and others added 6 commits July 24, 2024 18:26

error fix

702eba7

Merge branch 'prebid:master' into master_jun_24

e0ee391

import bidUtils.js in IdxBidadapter to reduce the code duplicataion

c174c9e

import bidUtils.js in IdxBidadapter to reduce the code duplicataion

65af09e

Error fix

d4c4bd7

Imported bidUtils library into redtram bid adapter

c291e6d

NikhilGopalChennissery and others added 2 commits August 8, 2024 13:36

import common library in mediabramaBidAdapter

510053a

Merge branch 'master' into master_jun_24

6324822

NikhilGopalChennissery added 2 commits August 8, 2024 14:15

import common library in loganBidAdapter to remove code duplication

e9c773e

Merge branch 'master_jun_24' of https://github.com/PrecisoSRL/Prebid.js…

dcb586f

… into master_jun_24

patmmccann reviewed Aug 12, 2024

View reviewed changes

libraries/bidUtils/bidUtils.js Outdated Show resolved Hide resolved

patmmccann reviewed Aug 12, 2024

View reviewed changes

libraries/bidUtils/bidUtilsCommon.js Outdated Show resolved Hide resolved

patmmccann self-assigned this Aug 12, 2024

removed storageManaser from library

8659a3a

NikhilGopalChennissery requested a review from patmmccann August 12, 2024 18:09

patmmccann requested changes Aug 14, 2024

View reviewed changes

NikhilGopalChennissery and others added 2 commits August 16, 2024 10:00

renderer.js changes reverted

c2b8c27

Merge branch 'prebid:master' into master_jun_24

0ccda46

NikhilGopalChennissery requested a review from patmmccann August 16, 2024 06:55

patmmccann approved these changes Aug 18, 2024

View reviewed changes

patmmccann merged commit 4835e08 into prebid:master Aug 18, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preciso : Added new library to remove code duplication in bid adapter #11868

Preciso : Added new library to remove code duplication in bid adapter #11868

NikhilGopalChennissery commented Jun 26, 2024

patmmccann commented Jun 26, 2024 •

edited

Loading

patmmccann commented Jun 26, 2024

NikhilGopalChennissery commented Jun 27, 2024 •

edited

Loading

patmmccann commented Jun 27, 2024

NikhilGopalChennissery commented Jun 28, 2024

patmmccann commented Jun 28, 2024

github-actions bot commented Jul 24, 2024

github-actions bot commented Jul 24, 2024

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 8, 2024

NikhilGopalChennissery commented Aug 9, 2024

patmmccann commented Aug 12, 2024

NikhilGopalChennissery commented Aug 12, 2024

patmmccann left a comment

patmmccann Aug 14, 2024

NikhilGopalChennissery Aug 16, 2024

NikhilGopalChennissery commented Aug 16, 2024

Preciso : Added new library to remove code duplication in bid adapter #11868

Preciso : Added new library to remove code duplication in bid adapter #11868

Conversation

NikhilGopalChennissery commented Jun 26, 2024

Type of change

Description of change

Other information

patmmccann commented Jun 26, 2024 • edited Loading

patmmccann commented Jun 26, 2024

NikhilGopalChennissery commented Jun 27, 2024 • edited Loading

patmmccann commented Jun 27, 2024

NikhilGopalChennissery commented Jun 28, 2024

patmmccann commented Jun 28, 2024

github-actions bot commented Jul 24, 2024

github-actions bot commented Jul 24, 2024

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 8, 2024

NikhilGopalChennissery commented Aug 9, 2024

patmmccann commented Aug 12, 2024

NikhilGopalChennissery commented Aug 12, 2024

patmmccann left a comment

Choose a reason for hiding this comment

patmmccann Aug 14, 2024

Choose a reason for hiding this comment

NikhilGopalChennissery Aug 16, 2024

Choose a reason for hiding this comment

NikhilGopalChennissery commented Aug 16, 2024

patmmccann commented Jun 26, 2024 •

edited

Loading

NikhilGopalChennissery commented Jun 27, 2024 •

edited

Loading