-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Typecheck bug in preactjs/preact#3934 #452
Fixes Typecheck bug in preactjs/preact#3934 #452
Conversation
…reserving functionality.
@marvinhagemeister @rschristian Let me know what you think and if any changes are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failure is due to us having an older version of Preact (without SignalLike
) as a devDep, nothing you necessarily need to worry about though I don't love the idea of increasing the minimum supported Preact version (if the user wants TypeScript support, anyways).
Thanks for the quick response! Let me know if I can help more with this or anything else. |
"chai": "^3.5.0", | ||
"copyfiles": "^1.0.0", | ||
"chai": "^4.3.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #453 for justification, but need to update some of these here w/ the type fix to satisfy CI.
We really appreciate the fix! ❤️ I'll try to cut a release in a bit, after my dinner. |
Added SignalLike as an option for default that fixes /preact/issues/3934 while preserving current functionality. This is a simple fix but it seems like it would do what's needed.