Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheking urls considering protocol-relative url #383

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

18choi18
Copy link

@18choi18 18choi18 commented Sep 25, 2020

When using the Router in a specific part of the web page, in other parts they may not know that they should add a native boolean attribute to a link tag for bypassing preact-router's link handling. Currently, in this case, if an anchor tag have protocol-relative url(ex, //www.11st.co.kr) for the value of href, the link can't avoid handling of preact-router because it starts with '/'.

Therefore, unintended handling occurs in the a tag that takes the protocol-relative url as the value of href. So I suggest modifying the regex.
From: If the value of href starts with '/'?
To: If the value of href starts with '/' but the next character is not '/'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant