Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: accept regular expression matching #227

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mingard
Copy link

@mingard mingard commented Aug 15, 2017

Overview

For more specific route matching, this PR introduces a basic regex match execution.

Example
paginated posts: posts/:page?[^\d+$]
single post: posts/:title?

This is only an interim measure to satisfy a project requirement, so I'm open to suggestions.

@developit
Copy link
Member

Might have odd interplay with the match ordering from #136

@mingard
Copy link
Author

mingard commented Sep 14, 2017

@developit I'll run some tests. It could prove benificial to introduce some acceptance tests ontop of the current unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants