Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pre-commit-2332 #1089

Closed

Conversation

rishabhjain1712
Copy link

Added a fix for address the issue of inconsistent mixing between tab and space indentation within the JSON content.

@asottile
Copy link
Member

asottile commented Sep 2, 2024

inconsistent indents aren't invalid json -- perhaps you want to use a formatter or a different hook entirely to enforce that

@asottile asottile closed this Sep 2, 2024
@asottile
Copy link
Member

asottile commented Sep 2, 2024

please in the future discuss changes before wasting time on them

@rishabhjain1712
Copy link
Author

rishabhjain1712 commented Sep 2, 2024

got it, this was my first contribution so didnt know much about how to go about these things.
will keep this in mind @asottile

@rishabhjain1712
Copy link
Author

@asottile if you dont mind can you guide me a little on how to contribute

@asottile
Copy link
Member

asottile commented Sep 3, 2024

generally it's best to start with an issue describing your problem before jumping to solutioneering. make sure it's something that's agreed upon first before spending a bunch of effort trying to build it

also unrelated to that: use a commit subject to describe what your change does rather than "fix pre-commit-2332" (which I don't even know what that's a reference to? issue 2332 doesn't exist yet?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants