Fix detail url #369
Merged
Fix detail url #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudigiesler
reviewed
Aug 28, 2024
| assert ( | ||
| meta["detail_url"] | ||
| == f"http://localhost/api/v2/pages/{self.low_result_page.id}/" | ||
| ) |
There was a problem hiding this comment.
Could we maybe have one test that just asserts the entire response? That way we can make sure none of the other meta fields have incorrect values, and we can ensure that future changes don't change the API?
rudigiesler
previously approved these changes
Aug 28, 2024
rudigiesler
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The detail_url in the Pages API is currently showing the current URL and not the detail URL, which causes a failure on one of our implementations.
Solution
We use
get_object_detail_urlto get the correct detail url for the Page. Trying to use super() and building on that doesn't work, as it seems to cause a cascade of errors when Assessments serialize a Page.Checklist