more process priority testing on the github test machine-environment

Adding documentation for the result of renice on various systems.
pradosoft · Jul 25, 2023 · 469417d · 469417d
1 parent b93ba6c
commit 469417d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/framework/Util/Helpers/TProcessHelper.php b/framework/Util/Helpers/TProcessHelper.php
@@ -291,6 +291,9 @@ public static function setProcessPriority(int $priority, ?int $pid = null): bool
 			}
 			$priority -= $pp;
 			$result = shell_exec("exec renice -n $priority -p $pid");
+			// On MacOS, working properly consists of returning nothing.  only errors return
+			// On the github linux test system it return "3539 (process ID) old priority 0, new priority 8"
+			//   for an error, it return: ...
 			echo('--' . $result . '--');
 			if (is_string($result) && strlen($result) > 1) {
 				return false;

diff --git a/tests/unit/Util/Helpers/TProcessHelperTest.php b/tests/unit/Util/Helpers/TProcessHelperTest.php
@@ -117,6 +117,7 @@ public function testIsRunning_Kill_Priority()
 		self::assertTrue(TProcessHelper::isRunning($pid));
 
 		self::assertTrue(is_int($processPriority = TProcessHelper::getProcessPriority($pid)));
+		self::assertTrue(TProcessHelper::setProcessPriority(TProcessHelper::WINDOWS_ABOVE_NORMAL_PRIORITY, $pid));
 		self::assertTrue(TProcessHelper::setProcessPriority(TProcessHelper::WINDOWS_BELOW_NORMAL_PRIORITY, $pid));
 		self::assertEquals(TProcessHelper::WINDOWS_BELOW_NORMAL_PRIORITY, TProcessHelper::getProcessPriority($pid));