Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DanglingLine ID in Eurostag example network with tie-lines #3154

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

jeandemanged
Copy link
Member

@jeandemanged jeandemanged commented Sep 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Quality

What is the current behavior?

Confusing NVH1_XNODE2 dangling line ID for dangling line between NHV1 and Xnode XNODE2.
(The other dangling line NHV1_XNODE1 is ok.)

What is the new behavior (if this is a feature change)?
NVH1_XNODE2 renamed NHV1_XNODE2

Does this PR introduce a breaking change or deprecate an API?

  • No BUT tests in downstream repos will need to adjust wherever needed

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged jeandemanged force-pushed the fix-eurostag-tutorial-ex1-danglingline-id-typo branch from 59debe5 to 988ca38 Compare September 24, 2024 07:49
Copy link

sonarcloud bot commented Sep 25, 2024

@flo-dup flo-dup merged commit ba4c73f into main Sep 25, 2024
7 checks passed
@flo-dup flo-dup deleted the fix-eurostag-tutorial-ex1-danglingline-id-typo branch September 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants