-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cgmes Import. Line and Substation containers. #2970
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es> # Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Quality Gate passedIssues Measures |
Hi @marqueslanauja, could you please fill in the current behaviour and the new behaviour in the description? That will help me a lot with the review. Thanks! |
Ok,
I will do it.
José Antonio.
…________________________________
De: rcourtier ***@***.***>
Enviado: miércoles, 18 de septiembre de 2024 10:48
Para: powsybl/powsybl-core ***@***.***>
Cc: Jose Antonio Marques ***@***.***>; Mention ***@***.***>
Asunto: Re: [powsybl/powsybl-core] Cgmes Import. Line and Substation containers. (PR #2970)
Hi @marqueslanauja<https://github.com/marqueslanauja>, could you please fill in the current behaviour and the new behaviour in the description? That will help me a lot with the review. Thanks!
—
Reply to this email directly, view it on GitHub<#2970 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMGBV6UWCRJVHOSZBVXJHMDZXE44BAVCNFSM6AAAAABF4VLVSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJXHA3DSNRZGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Quality Gate passedIssues Measures |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Cgmes context:
IIDM context:
What is the current behavior?
What is the new behavior (if this is a feature change)?
SubstationIdMapping class.
Define the voltageLevels of the IIDM model:
Each cgmes voltageLevel not connected to other containers by switches defines a voltageLevel in the IIDM model (one to one). There is not need of finding a representative for them.
Next step. Determine the fictitious voltageLevels that must be created:
It is not expected to create a voltageLevel for a substationContainer including connectivity nodes as it must always be connected by switches to other containers.
Last step. Find a reference voltageLevel.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: