Proposition to create a complex matrix class #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: JB-H <jbheyberger@gmail.com>
Signed-off-by: JB-H <jbheyberger@gmail.com>
|
annetill
reviewed
May 4, 2024
| } | ||
|
|
||
| public static DenseMatrix getFortescueOrInverseMatrix(boolean isInverse) { | ||
| DenseMatrix mFortescueOrInverse = new DenseMatrix(6, 6); | ||
| public static ComplexMatrix createComplexMatrix(boolean isInverse) { |
There was a problem hiding this comment.
Maybe just inverse here for the boolean name.
| double t22 = realMatrix.get(rowIndexInCartesian + 1, colIndexInCartesian + 1); | ||
|
|
||
| double epsilon = 0.00000001; | ||
| if (FastMath.abs(t11 - t22) > epsilon) { |
There was a problem hiding this comment.
These two if bloc can be shared, and with the first exception of your method, you can introduce a string variable for exception message.
geofjamg
approved these changes
May 6, 2024
annetill
changed the title
4 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
It is a new feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
complex matrix handled and used to generate Fortescue matrices
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: