Created adapter blueprint with db name in config environment #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmarcum
changed the title
| @@ -0,0 +1,32 @@ | |||
| import { Adapter } from 'ember-pouch/index'; | |||
There was a problem hiding this comment.
you don't need index: import { Adapter } from 'ember-pouch';
|
👍 |
|
Thanks for the code review, fixed those issues. |
|
I think this is a good idea. I think it would be more in keeping with Ember style for the config key to be camelized ( Sorry again for the slow response. |
| live: true, | ||
| retry: true | ||
| }); | ||
| } |
There was a problem hiding this comment.
This block is double-indented (4 spaces instead of 2).
|
Ok updated the key and added a section to the README |
|
Great, thanks. If you could rebase & squash we'll be ready to merge. |
|
closing in favor of #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw in the dummy app adapter that you had a TODO to grab the db name from some external source. I think this is the community's preferred method is sticking this stuff in the config. I went ahead and created an adapter blueprint to match what's in the readme and to pull in the db name from the config.